One other 'con' I'd like to bring up, besides Josh's (which I agree 100%
with), is the following.
I find inconsistent style frustrating, true. But what I find even more
frustrating is when I'm trying to debug and I want to know why a line of
code was last changed.
If you reformat the entire codebase, even for something like uPortal
5.0. Then the history of trying to determine why a line of code is what
it is, will be difficult, to potentially impossible (depends on how the
change is made).
It's not enough of a reason to say don't do this. But for me, it would
actually be more annoying then the style problems are themselves.
---- Cris J H
On 11/06/2014 03:32 PM, James Wennmacher wrote:
100 (or worse yet 80) characters on a line! Oh man! I'm going to have
to use shorter variable and method names. At least I only need to
indent 2 spaces now. That will help. :-)
+1 on a 'common' standard, especially if we can get it enforced in the
build (as annoying as I find that is sometimes). Google's is great.
James Wennmacher - Unicon
480.558.2420
On 11/06/2014 08:04 AM, Andrew Petro wrote:
uPortal developers,
I think it would be wise for uPortal to adopt tighter code style
conventions (and to enforce these in the release process via build
automation, since without automation style conventions will not be
adhered to.)
I think those code conventions should be Google's.
https://google-styleguide.googlecode.com/svn/trunk/javaguide.html
https://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml
etc.
The product has a heap of code of varying style. I'd see a changeset
to pervasively adjust style to the convention as only appropriate for
a MAJOR release. As in, uPortal 5.
So. This is the initial conversation-starting email expressing
intention to advocate for this improvement for uPortal 5.
Andrew
--
You are currently subscribed to [email protected] as:
[email protected]
To unsubscribe, change settings or access archives, see
http://www.ja-sig.org/wiki/display/JSG/uportal-dev
--
You are currently subscribed to [email protected] as:
[email protected]
To unsubscribe, change settings or access archives, see
http://www.ja-sig.org/wiki/display/JSG/uportal-dev
