Benito et al., I believe this change will help with these efforts:
- https://issues.jasig.org/browse/UP-4456 <https://issues.jasig.org/browse/UP-4456> I’m going to organize it into a pull request. drew > On May 5, 2015, at 2:18 PM, Benito J. Gonzalez <[email protected]> wrote: > > Yep, you got it. That is how it should work. > > Thanks! > > Benito J. Gonzalez - Unicon > [email protected] <mailto:[email protected]> > 480.558.2360 > > > >> On May 5, 2015, at 1:41 PM, James Wennmacher <[email protected] >> <mailto:[email protected]>> wrote: >> >> Benito, >> >> I think >> >> <pags-group >> script="classpath://org/jasig/portal/io/import-pags-group_v4-1.crn >> <classpath://org/jasig/portal/io/import-pags-group_v4-1.crn>"> >> <name>Member of Students (PAGS)</name> >> <description>Member of Students group</description> >> <selection-test> >> <test-group> >> <member-of-group>Students</member-of-group> >> <not-member-of-group>Test Users</not-member-of-group> >> </test-group> >> </selection-test> >> </pags-group> >> >> is great and a much cleaner solution. I want to verify you could do >> something like the following: >> >> <pags-group >> script="classpath://org/jasig/portal/io/import-pags-group_v4-1.crn >> <classpath://org/jasig/portal/io/import-pags-group_v4-1.crn>"> >> <name>Member of Students (PAGS)</name> >> <description>Member of Students group</description> >> <selection-test> >> <test-group> >> <member-of-group>Students</member-of-group> >> <member-of-group>English Majors</member-of-group> >> <not-member-of-group>Test Users</not-member-of-group> >> <not-member-of-group>Boring Users</not-member-of-group> >> <test> >> <attribute-name>agentDevice</attribute-name> >> >> <tester-class>org.jasig.portal.groups.pags.testers.PropertyInvertedRegexTester</tester-class> >> >> <test-value>org.jasig.portal.http.header.userAgent.mobile.regex.pattern</test-value> >> </test> >> </test-group> >> </selection-test> >> <selection-test> >> <test-group> >> <member-of-group>Faculty</member-of-group> >> <not-member-of-group>BannedFaculty</not-member-of-group> >> </test-group> >> </selection-test> >> </pags-group> >> >> e.g. following the rules that test-group members are ANDed together, >> selection-tests are ORed together so you can have multiple member-of-group >> and not-member-of-group and 1 or more test elements in a test-group. >> James Wennmacher - Unicon >> 480.558.2420 >> On 05/04/2015 06:15 PM, Benito J. Gonzalez wrote: >>> All, >>> >>> My current design supports PAGS group definitions as shown by the following >>> simple example: >>> >>> <pags-group >>> script="classpath://org/jasig/portal/io/import-pags-group_v4-1.crn >>> <classpath://org/jasig/portal/io/import-pags-group_v4-1.crn>"> >>> <name>Member of Students (PAGS)</name> >>> <description>Member of Students group</description> >>> <selection-test> >>> <test-group> >>> <adhoc-group-test> >>> <include> >>> <group-name>Students</group-name> >>> </include> >>> <exclude> >>> <group-name>Test Users</group-name> >>> </exclude> >>> </adhoc-group-test> >>> </test-group> >>> </selection-test> >>> </pags-group> >>> >>> Working on the implementation, I realized that there was no need for >>> multiple adhoc-group-test stanzas since all the tests in the surrounding >>> test-group are AND-ed together as are the group tests inside >>> adhoc-group-test nodes. >>> >>> As I consider persistence, it dawned on me that there was not need for a >>> parent adhoc-group-test for the inner member-of and not-member-of tests >>> since there is a 1-to-1 correspondence to the test-group. >>> >>> Would the following be an improvement or is there an advantage to the extra >>> stanzas? >>> >>> <pags-group >>> script="classpath://org/jasig/portal/io/import-pags-group_v4-1.crn >>> <classpath://org/jasig/portal/io/import-pags-group_v4-1.crn>"> >>> <name>Member of Students (PAGS)</name> >>> <description>Member of Students group</description> >>> <selection-test> >>> <test-group> >>> <member-of-group>Students</member-of-group> >>> <not-member-of-group>Test Users</not-member-of-group> >>> </test-group> >>> </selection-test> >>> </pags-group> >>> >>> >>> One thought is that testing for group membership could be more efficient if >>> all the group tests were done together. Yet, that code could be rolled up >>> into the test-group class, TestGroup. >>> >>> Thoughts? >>> >>> Benito J. Gonzalez - Unicon >>> [email protected] <mailto:[email protected]> >>> 480.558.2360 >>> >>> >>>> <adhoc-group-test> >>>> <include> >>>> <group-name>Students</group-name> >>>> <group-name>Mobile Device Access</group-name> >>>> </include> >>>> <exclude> >>>> <group-name>Testers</group-name> >>>> </exclude> >>>> </adhoc-group-test> >>> >>> -- >>> >>> You are currently subscribed to [email protected] >>> <mailto:[email protected]> as: [email protected] >>> <mailto:[email protected]> >>> To unsubscribe, change settings or access archives, see >>> http://www.ja-sig.org/wiki/display/JSG/uportal-dev >>> <http://www.ja-sig.org/wiki/display/JSG/uportal-dev> >> -- >> >> You are currently subscribed to [email protected] >> <mailto:[email protected]> as: [email protected] >> <mailto:[email protected]> >> To unsubscribe, change settings or access archives, see >> http://www.ja-sig.org/wiki/display/JSG/uportal-dev >> <http://www.ja-sig.org/wiki/display/JSG/uportal-dev> > -- > > You are currently subscribed to [email protected] as: > [email protected] > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/uportal-dev -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/uportal-dev
