Steve Langasek has proposed merging lp:~vorlon/upstart/lp.980917-redux into
lp:upstart.
Requested reviews:
Upstart Reviewers (upstart-reviewers)
For more details, see:
https://code.launchpad.net/~vorlon/upstart/lp.980917-redux/+merge/118461
Slight improvements to the landed fix for bug #980917, which try to minimize
the number of unnecessary filesystem accesses when trying to determine
whether to mount devtmpfs.
--
https://code.launchpad.net/~vorlon/upstart/lp.980917-redux/+merge/118461
Your team Upstart Reviewers is requested to review the proposed merge of
lp:~vorlon/upstart/lp.980917-redux into lp:upstart.
=== modified file 'init/main.c'
--- init/main.c 2012-08-03 15:47:59 +0000
+++ init/main.c 2012-08-07 01:32:18 +0000
@@ -247,22 +247,12 @@
/* Check if key devices already exist; if they do,
* we should assume we don't need to mount /dev.
*/
- if (system_check_file ("/dev/null", S_IFCHR, makedev (1, 3)) < 0)
- needs_devtmpfs = 1;
-
- if (system_check_file ("/dev/console", S_IFCHR, makedev (5, 1)) < 0)
- needs_devtmpfs = 1;
-
- if (system_check_file ("/dev/tty", S_IFCHR, makedev (5, 0)) < 0)
- needs_devtmpfs = 1;
-
- if (system_check_file ("/dev/kmsg", S_IFCHR, makedev (1, 11)) < 0)
- needs_devtmpfs = 1;
-
if (system_check_file ("/dev/ptmx", S_IFCHR, makedev (5, 2)) < 0)
- needs_devtmpfs = 1;
-
- if (system_check_file ("/dev/pts", S_IFDIR, 0) < 0)
+ || system_check_file ("/dev/pts", S_IFDIR, 0) < 0
+ || system_check_file ("/dev/kmsg", S_IFCHR, makedev (1, 11)) < 0
+ || system_check_file ("/dev/null", S_IFCHR, makedev (1, 3)) < 0
+ || system_check_file ("/dev/console", S_IFCHR, makedev (5, 1)) < 0
+ || system_check_file ("/dev/tty", S_IFCHR, makedev (5, 0)) < 0)
needs_devtmpfs = 1;
if (needs_devtmpfs) {
--
upstart-devel mailing list
[email protected]
Modify settings or unsubscribe at:
https://lists.ubuntu.com/mailman/listinfo/upstart-devel
