Review: Disapprove I don't think mountall should special case fsck.btrfs. fsck.$fs is a standard interface; btrfs-tools should be supporting this, even if it means making it a symlink to /bin/true - mountall should not be special-casing btrfs, btrfs should be complying with the interfaces.
I'm also not happy with the "major_zero" change. This is way too magic. I think we should get an explanation of why this is the correct check here before including such code. -- https://code.launchpad.net/~xnox/ubuntu/saucy/mountall/btrfs/+merge/177822 Your team Upstart Reviewers is requested to review the proposed merge of lp:~xnox/ubuntu/saucy/mountall/btrfs into lp:ubuntu/mountall. -- upstart-devel mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/upstart-devel
