Review: Needs Fixing

Hi Cameron,

Thanks for updating. There is still a problem with inet_pton(): the test should 
error if the value returned != 1 since currently all valid IPv6 addresses are 
rejected. Please could you fix that up and test.

I'm testing this with a job that specifies:

start on socket PROTO=inet6 PORT=80 ADDR=::1
script
echo ok
set
end script

Then running the event monitor:

$ upstart-monitor &

Then, running the bridge in debug mode in the foreground:

$ sudo ./upstart-socket-bridge --debug

And finally connecting to port 80 via IPv6:

$ echo foo | socat 'tcp6-connect:[::1]:80' -

Thanks!

-- 
https://code.launchpad.net/~cameronnemo/upstart/ipv6/+merge/204599
Your team Upstart Reviewers is subscribed to branch lp:upstart.

-- 
upstart-devel mailing list
[email protected]
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/upstart-devel

Reply via email to