On Wed, Aug 18, 2010 at 1:39 PM, simon qian wrote:
> The driver is tested OK.
> It's really simple to implement driver for UrJTAG.
> I didn't setup the USB_TO_XXX framework, because
> it's just unnecessary.
>
> Check the patch in the attachment.
style things to fix:
- use spaces and not tabs to indent. urjtag uses 4 spaces per
indentation block.
- use "if (", not "if("
- the func style is: "foo (arg1, arg2, arg3);" ... yours has a
variety of styles that dont match this
- vsllink_tap_execute() and vsllink_init() and vsllink_done() and
urj_tap_cable_vsllink_set_frequency() have blocks with extra
indentation for no reason
- urj_tap_cable_vsllink_set_frequency() should be named just
vsllink_set_frequency()
- do not use __FUNCTION__ or __func__ ... urj_log() takes care of
things for you
- use /* comments */ and not // comments
bug fixes:
- wrap all your messages with _(...): urj_log (_("foo"), ....);
- return URJ_STATUS_XXX and not 0/-1/1/-2/whatever
- your init func leaks memory on error. see "disable cdc device" for example.
> jtag> cable vsllink
> Versaloon(0x15)by Simon(compiled on Aug 16 2010)(buffer size 12288 bytes)
i guess most of that output is coming from the usb device and not your
cable driver ?
-mike
------------------------------------------------------------------------------
This SF.net email is sponsored by
Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev
_______________________________________________
UrJTAG-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/urjtag-development
