On Sat, 18 Jun 2011, Mike Frysinger wrote: Thanks very much for the review, Mike. Most of the suggestions look easy to fix.
> On Thursday, June 16, 2011 22:12:36 steve tell wrote: >> --- /dev/null >> +++ b/urjtag/bindings/python/urj_helpers.c >> @@ -0,0 +1,161 @@ >> + * Additional urjtag cain operations. >> + * These are not language-binding specific, but do help in writing of >> concise >> + * language bindings. In theory, this code could someday be merged into >> + * the core urjtag library. > > let's do that now rather than later OK, I'll work up a multipart patchset that does that first. Those routines all include code copied from src/cmd/cmd_*.c . It will probably turn out cleanest to refactor the cmd_ routine to call the new routines. For example, urj_chain_cable() is almost the same as the second half of cmd_cable_run(). Having cmd_cable_run() call urj_chain_cable() will essentialy split the command-line parsing from the programmer-friendly API, avoiding duplicated code and easing future maintenance. This will make life easier for other language-binding writers too. Looks like a better name for the new routine might be urj_tap_chain_cable(), But i'll study the existing code further to confirm. Steve ------------------------------------------------------------------------------ EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ UrJTAG-development mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/urjtag-development
