On Wed, Jun 29, 2011 at 3:30 PM, Mike Frysinger <[email protected]> wrote: > On Wednesday, June 29, 2011 13:53:37 Jie Zhang wrote: >> On Tue, Jun 28, 2011 at 10:41 PM, Mike Frysinger <[email protected]> wrote: >> > in looking at this code, i wonder why ice_hex_init() exists. shouldnt >> > hex.c:hex_init() have this logic ? >> >> I'm not sure why hex_init does not have this logic. My guess is it's >> not all users of hex_value need this logic. For example, gcc calls >> hex_init directly but some BFD files call it with such a wrapper. It >> happens to us that we'd better have such a wrapper such that when you >> updating firmware for multiple ICE-100B cables in one UrJTAG session >> hex_init is only called once. > > lets move the logic into our hex_init() so we dont have to duplicate it across > other pieces of urjtag (and they'd still be wrong) > I'd like to keep imported file intact to ease future merge. But it seems hex.c is unlikely to change in future. So I think it's good for us to modify our version of hex.c.
btw, do you have more comments on this: http://www.mail-archive.com/[email protected]/msg00831.html Jie ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ UrJTAG-development mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/urjtag-development
