On Wednesday, August 24, 2011 10:42:33 Márton Miklós wrote:
> The attached patch add support for the Freescale MPC8313's local bus.

there were style problems:
 - use "foo (args)", not "foo( args )"
 - indentation is 4 spaces, not 8
 - no trailing whitespace/newlines

you also forgot to update src/bus/Makefile.am, so the driver never actually 
got built.  then i hit a build failure as you didnt include the NWP define.

i fixed these up and committed it, but please be more careful with future 
patches.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

------------------------------------------------------------------------------
EMC VNX: the world's simplest storage, starting under $10K
The only unified storage solution that offers unified management 
Up to 160% more powerful than alternatives and 25% more efficient. 
Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
_______________________________________________
UrJTAG-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/urjtag-development

Reply via email to