Hi Mike, Mike Frysinger wrote: > On Monday 05 December 2011 16:30:13 Németh Márton wrote: >> Add the list subcommand for cable command. This subcommand will list >> all the connected cables and helps to find out the description and serial >> number when it is more than one device is connected with the same driver. > > this doesn't apply against current git, so it'll need to be updated
So the latest version is in git. This was not clear for me even after reading http://urjtag.org/book/_development.html#_how_to_contribute where SVN was mentioned. > rather than making it a cable sub-command, can probably use a general "cable > list" like we have with "cable probe" I'll have a look on the "cable probe" command, thanks for the hint. >> --- urjtag-0.10.orig//src/cmd/cable.c >> +++ urjtag-0.10/src/cmd/cable.c >> >> + if (strcasecmp( params[2], "list" ) == 0) > > the style is: > func (arg1, arg2) > >> + if (!cable) { >> + printf( _("%s(%d) malloc failed!\n"), >> __FILE__, > __LINE__); >> + return 1; >> + } > > current git no longer writes to stdout ... we have logging funcs for that > >> +static void >> +usbconn_ftd2xx_list(usbconn_cable_t *conn) >> +{ >> + FT_STATUS ftStatus; >> + DWORD dwLibraryVer; >> + DWORD dwDriverVer; >> + FT_HANDLE ftHandle; >> + FT_HANDLE ftHandleTemp; >> + DWORD numDevs; >> + DWORD i; >> + DWORD Flags; >> + DWORD ID; >> + DWORD Type; >> + DWORD LocId; >> + char SerialNumber[16]; >> + char Description[64]; >> + LONG lComPortNumber; > > sorry, but we don't use windows types here. you'll have to use the proper > ones. and avoid CamelCase when naming variables. > -mike Thanks for the review and the feedback. I'll take a look on the latest git and see what is already there and how can this functionality be added to that version. Regards, Márton Németh ------------------------------------------------------------------------------ Cloud Services Checklist: Pricing and Packaging Optimization This white paper is intended to serve as a reference, checklist and point of discussion for anyone considering optimizing the pricing and packaging model of a cloud services business. Read Now! http://www.accelacomm.com/jaw/sfnl/114/51491232/ _______________________________________________ UrJTAG-development mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/urjtag-development
