What are your thoughts on the file urjtag/data/atheros/ar2312/ar2312.
Perhaps it is not clear, but patch 1 of 2 copies the contents
of urjtag/data/atheros/ar2312/ar2312 to urjtag/data/atheros/ar2313/ar2313.
Patch 2 of 2 modifies the poke command that is needed to correctly
initialize the ar2313 hardware to allow flash detection. Without the poke
command, the ar2313 is unable to successfully detect the flash. I assume
that the original author of the ar2312 code had a similar problem with
flash detection on ar2312 hardware. Is there a better place to put this
necessary initialization command? If it is unacceptable to have this kind
of initialization command in the datafile, should we remove this code
from urjtag/data/atheros/ar2312/ar2312 as well? Assuming that the poke
command is necessary to correctly initialize the hardware for flash
detection, the removal of this code from the ar2312 datafile could be seen
as a regression for the users of that hardware. However, the removal of
the poke command from the ar2312 datafile makes it compatible with ar2313
hardware, although it leaves the ar2313 hardware (and perhaps ar2312
hardware) in a state where it is not yet able to detect the flash chip. I
would love to get further input on these matters.
Stanley Pinchak
On Wed, May 8, 2013 at 10:37 PM, Mike Frysinger <vap...@gentoo.org> wrote:
> On Wednesday 01 May 2013 00:35:12 Stanley Pinchak wrote:
> > ---
> > urjtag/data/atheros/ar2313/ar2313 | 52
> > +++++++++++++++++++++++++++++++++++++ 1 file changed, 52 insertions(+)
> > create mode 100644 urjtag/data/atheros/ar2313/ar2313
>
> you can use `git send-email` to send things properly rather than attaching
> them
>
> > --- /dev/null
> > +++ b/urjtag/data/atheros/ar2313/ar2313
> > ...
> > +initbus ejtag
> > +endian big
> > +#Enable flash read/write
> > +poke 0x58400000 0x100e3ce1
>
> data files shouldn't execute random commands like this
> -mike
>
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and
their applications. This 200-page book is written by three acclaimed
leaders in the field. The early access version is available now.
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
_______________________________________________
UrJTAG-development mailing list
UrJTAG-development@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/urjtag-development
