On Sat, Aug 03, 2019 at 09:08:03PM +0200, k...@aspodata.se wrote: > Geert Stappers: > > On Sat, Aug 03, 2019 at 05:00:22PM +0200, Karl Hammar wrote: > > > I found too many things are called part, so I change > > > part->part to part->part_name, ditto for manufaturer > > > > > > > Is it OK that I submit the patch this long commit message? > > > > > > Too many things are called part. > > Changed part->part to part->part_name, > > ditto for manufacturer. > > Yes. OK
Karl has now his first commit in UrJTAG. Nice. > Generally, for me you can use whatever message you want if you think > you have a better one. Acknowledge on that. But it is NOT how it will be done. The commit message is essential part of the contributed patch. They do come from 'Author: ' in each git commit. It is not up to those who have more git repository privileges to temper^Wmodify commit messages. Exceptions, such as getting a first commit in, given. Normal routine is * All patches get reviewed * Good enough patches get applied * Not yet good enough patches get further discussion * Patches too far from good enought get rejection Groeten Geert Stappers -- Leven en laten leven _______________________________________________ UrJTAG-development mailing list UrJTAG-development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/urjtag-development
