On Sun, Dec 08, 2019 at 02:19:47PM +0100, Jiri Gaisler wrote:
> Hello,
>
> this is a patch to add a bus driver for the AHBJTAG core in grlib/leon3
> systems. It allows to make 32-bit single and burst accesses on the
> AHBÂ bus in a grlib SOC. I have been using it with FT2232 cables for
> about a year and it works well without any issues.
Acknowledge. I'm about to apply to patch with some modification.
Please provide feedback on the _proposed_ modififcations.
> From b1cefaed561204d6caf7e656f541d4e76284a40c Mon Sep 17 00:00:00 2001
> From: Jiri Gaisler <j...@gaisler.se>
> Date: Mon, 19 Mar 2018 16:01:38 +0100
> Subject: [PATCH 1/1] Add bus driver for the GRLIB AHBJTAG debug interface.
>
> * Used mainly for LEON3/4 processors.
> * See www.gaisler.com for details.
I do miss that information in the actual source files.
> --- a/urjtag/ChangeLog
> +++ b/urjtag/ChangeLog
> @@ -1,3 +1,6 @@
> +2019-12-03 Jiri Gaisler <j...@gaisler.se>
> + * src/bus/ahbjtag.c: New file. Implements bus driver for GRLIB AHBJTAG
> core.
> +
Git HEAD has different context. I'll do the extra work in handling it.
> 2019-11-25 Alexander Voropay <a...@sensi.org>
> * git log hash as version number
>
> --- /dev/null
> +++ b/urjtag/src/bus/ahbjtag.c
> @@ -0,0 +1,333 @@
> +/*
> + * $Id$
No needed.
Relic from RCS, CVS and SVN era.
I want to drop it.
> + * Bus driver for the GRLIB AHBJTAG core.
> + *
... GPL ...
> + *
> + * Written by Jiri Gaisler <j...@gaisler.se>, 2018.
> + * Based on fjmem.c
> + *
> + */
> +
> +#include <sysdep.h>
> +
> +#include <stdlib.h>
> +#include <stdint.h>
> +#include <string.h>
> +
> +#include <urjtag/log.h>
> +#include <urjtag/part.h>
> +#include <urjtag/bus.h>
> +#include <urjtag/chain.h>
> +#include <urjtag/cmd.h>
> +#include <urjtag/tap.h>
> +#include <urjtag/data_register.h>
> +#include <urjtag/tap_register.h>
> +#include <urjtag/part_instruction.h>
> +
> +#include "buses.h"
> +#include "generic_bus.h"
> +
> +#undef DEBUG
Why?
I want to drop it
> +#define AHBJTAG_ADDR_NAME "AINST"
> +#define AHBJTAG_AREG_NAME "ADDR"
...
> +
> +
> +/*
> + Local Variables:
> + mode:C
> + tab-width:2
> + indent-tabs-mode:t
> + End:
> +*/
Also something I want to drop.
What will I break if I remove the '#undef DEBUG'?
If it is nothing, then say so.
Groeten
Geert Stappers
--
Leven en laten leven
_______________________________________________
UrJTAG-development mailing list
UrJTAG-development@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/urjtag-development
