On Sat, Oct 20, 2012 at 10:09 AM, Ian Ward <[email protected]> wrote: > On Sat, Oct 20, 2012 at 9:20 AM, Patrick Totzke <[email protected]> > wrote: >> >> ListBox.keypress and kids: >> https://github.com/wardi/urwid/blob/master/urwid/listbox.py#L1015 and >> https://github.com/wardi/urwid/blob/master/urwid/listbox.py#L1039 up until >> L1087 >> seems to be duplicated code in _keypress_up and _keypress_down. >> Some of it also seems to be present in _keypress_pageup/down. >> I'm not sure what it does exactly, but its certainly a good candidate for >> a helper method. >> Maybe you also want a ListBox._make_focus_visible() and just call this in >> render() >> before doing anything else. > > Wait, did I say ideas? I meant patches. Silly me. ;-) Failing > that put it in a ticket so I can look at it when I have time.
Also, at one point I started working on an HListBox class, this is its removal: http://excess.org/urwid/changeset/242%3A3329aa4d9a65 Any ListBox refactoring should be done with an eye to pulling out common ListBox/HListBox code into a BaseListBox class when possible. Ian _______________________________________________ Urwid mailing list [email protected] http://lists.excess.org/mailman/listinfo/urwid
