Hi Michael Thanks for taking a look at the samples. Comments in-line...
Regards Simon snip... > > As far as I can tell, testing/itest/properties has nothing to do with > SDO, that comment in the itest/pom appears to be misleading? I think you right. I took a quick look in the pom and it doesn't mention SDO. I was misslead by the comment. I seem to remember there were some SDO property tests, i.e, an SCA porperty whose type is an SDO, but maybe they were elsewhere. > I'm > proposing a first few small fixes towards making > testing/itest/properties pass in > https://github.com/vorburger/tuscany-sca-2.x/commit/da22acd05d0a05fd9d90c35f167672e32870e194 Excellent. If you want to get this in the code base, capture the diff, attach it to a JIRA and press the "grant to ASF" button I can check it on for you. > - but this is completely unrelated to SDO - would you agree or am I > not getting it? Note that the tests in modules/databinding-sdo & > databinding-sdo-axiom both pass. Sounds right. to me. > > I've meanwhile found > https://issues.apache.org/jira/browse/TUSCANY-3469, but noticed this > was removed from current SVN trunk and 2.0-Beta3 distrib. On > https://github.com/vorburger/tuscany-sca-2.x/tree/trunk/samples/getting-started/helloworld-webservice-sdo > is my attempt to get an (adapted) version of what was the > helloworld-ws-sdo.zip attached to that JIRA to pass again - > unfortunately currently failing with a java.lang.NullPointerException > at > org.apache.tuscany.sca.databinding.sdo.SDOTypeHelper.addResolvedXSDs(SDOTypeHelper.java:172). > My understanding of Tuscany's internals, after scanning over its code > over the week-end, are too limited to understand how this could ever > have worked or where to start fixing this - the ModelResolver resolver > is passed in from WSDLContractBuilder build where a null is > hard-coded. Anybody willing to help getting this > helloworld-webservice-sdo to pass and included in trunk again? Or > point to what what would have to be done to get it to pass. We started from scratch with the samples as there were too may that didn't work properly. I don't think it was anti-SDO in particular. I'd have to look at the test/code to work out what's going on. I may get a chance later in the week. > > I've also attempted to build a helloworld-webservice-sdo-dynamic > example, same thing with dynamic SDO and no code generation, see > https://github.com/vorburger/tuscany-sca-2.x/commit/9a0fc93f2ba382583c74d480e03bdc36e79418f4. > That currently fails with the following exception: > > org.apache.tuscany.sca.databinding.TransformationException: > com.sun.xml.internal.bind.v2.runtime.IllegalAnnotationsException: 2 > counts of IllegalAnnotationExceptions > commonj.sdo.DataObject is an interface, and JAXB can't handle interfaces. > this problem is related to the following location: > at commonj.sdo.DataObject > at protected commonj.sdo.DataObject sample.jaxws.SayHello.arg0 > at sample.jaxws.SayHello > commonj.sdo.DataObject does not have a no-arg default constructor. > this problem is related to the following location: > at commonj.sdo.DataObject > at protected commonj.sdo.DataObject sample.jaxws.SayHello.arg0 > at sample.jaxws.SayHello > at > org.apache.tuscany.sca.databinding.jaxb.axiom.JAXB2OMElement.transform(JAXB2OMElement.java:60) > > because for some reason it's trying to do JAXB instead of SDO data > binding in this case... anybody willing to advise what I'm doing wrong > in this proposed example, and how to fix it? It looks like it doesn't know that DataObject means SDO. It maybe that the SDO data binding it not fully enabled for some reason. I'll give it a try here an see if I get the same result. > > While playing with this I did found one issue which I think is a bug > in SDOContextHelper which may have crept into 2.x but gone unnoticed > due to the removed SDO examples... before hitting above, you'd get a > java.lang.NullPointerException at > org.apache.tuscany.sca.databinding.sdo.ImportSDOProcessor.importWSDL(ImportSDOProcessor.java:176) > - addressed by > https://github.com/vorburger/tuscany-sca-2.x/commit/8822ba1b3b1560d01879bceb9970b165be16340c > - you may want to integrate that? JIRA? (And a TC for this should be > added in SDOContextHelperTestCase I guess.) Again, if you want to create a JIRA/Patch I can apply it. > > -- Apache Tuscany committer: tuscany.apache.org Co-author of a book about Tuscany and SCA: tuscanyinaction.com
