Awesome! Could you attach that to a Jira issue so we don't forget it ? Cheers!
-g On Feb 8, 2010, at 11:46 AM, Rico Jansen wrote: > > > 2010/1/29 Grégory Joseph <[email protected]> > > Hi Rico, > > There *should* be a better way; essentially, the component that creates this > "page-comments" forum should be site-aware, and create a new comments-forum > for each site. ("forum" because that's the generic name of this structure, > whether it's used for commenting or forum discussions, it's the exact same > backend) > > I don't have the sources right here, ping me again if you don't find right > away where this happens. Patches most welcome as usual ;) > > > I have found the spots the forum name is set. I have made changes to use the > site name, my first attempt was > through the site object but that resulted in either the theme name or the > name of the site definition. > I now use the root node of the content the paragraph is placed in. I have > delegated this to a util class that is > used by both paragraphs. I also introduced a parameter called useSiteName to > enable the site awareness > behaviour. It does require someone the create the forum called by this, and > set the corresponding > acl' s for the users. > > Attached is the diff containing: > - changes to the bootstrap xml's for the paragraphs (default not using the > site name). > - changes to the java code of PageComments.java and LatestComments.java > - a CommentingUtil class containing the method to determine the forum name > > -- > Rico Jansen ([email protected]) > "You call it untidy, I call it LRU ordered" -- Daniel Barlow > > <commenting.diff> ---------------------------------------------------------------- For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: <[email protected]> ----------------------------------------------------------------
