Hallo Petter,
On Sun, 9 Sep 2012 14:15:02 +0200, Peter Hüwe wrote:
> I created a patch for your proposed solution, I moved the stub driver to the
> end in order to have only one big if HAS_IOMEM.
There is a problem with the mux chip drivers, which then no longer
depend on HAS_IOMEM. Also, I think it is about time to admit that
i2c-stub does not fit under "I2C Hardware Bus support". It is a driver
for development, not hardware support.
So I propose the following instead:
drivers/i2c/Kconfig | 14 +++++++++++++-
drivers/i2c/busses/Kconfig | 14 +-------------
drivers/i2c/muxes/Kconfig | 2 +-
3 files changed, 15 insertions(+), 15 deletions(-)
--- linux-3.6-rc4.orig/drivers/i2c/Kconfig 2012-07-21 22:58:29.000000000
+0200
+++ linux-3.6-rc4/drivers/i2c/Kconfig 2012-09-09 18:34:08.169196654 +0200
@@ -4,7 +4,6 @@
menuconfig I2C
tristate "I2C support"
- depends on HAS_IOMEM
select RT_MUTEXES
---help---
I2C (pronounce: I-squared-C) is a slow serial bus protocol used in
@@ -86,6 +85,19 @@ config I2C_SMBUS
source drivers/i2c/algos/Kconfig
source drivers/i2c/busses/Kconfig
+config I2C_STUB
+ tristate "I2C/SMBus Test Stub"
+ depends on EXPERIMENTAL && m
+ default 'n'
+ help
+ This module may be useful to developers of SMBus client drivers,
+ especially for certain kinds of sensor chips.
+
+ If you do build this module, be sure to read the notes and warnings
+ in <file:Documentation/i2c/i2c-stub>.
+
+ If you don't know what to do here, definitely say N.
+
config I2C_DEBUG_CORE
bool "I2C Core debugging messages"
help
--- linux-3.6-rc4.orig/drivers/i2c/busses/Kconfig 2012-09-08
09:36:32.086553711 +0200
+++ linux-3.6-rc4/drivers/i2c/busses/Kconfig 2012-09-09 18:33:58.598196535
+0200
@@ -3,6 +3,7 @@
#
menu "I2C Hardware Bus support"
+ depends on HAS_IOMEM
comment "PC SMBus host controller drivers"
depends on PCI
@@ -850,19 +851,6 @@ config I2C_SIBYTE
help
Supports the SiByte SOC on-chip I2C interfaces (2 channels).
-config I2C_STUB
- tristate "I2C/SMBus Test Stub"
- depends on EXPERIMENTAL && m
- default 'n'
- help
- This module may be useful to developers of SMBus client drivers,
- especially for certain kinds of sensor chips.
-
- If you do build this module, be sure to read the notes and warnings
- in <file:Documentation/i2c/i2c-stub>.
-
- If you don't know what to do here, definitely say N.
-
config SCx200_I2C
tristate "NatSemi SCx200 I2C using GPIO pins (DEPRECATED)"
depends on SCx200_GPIO
--- linux-3.6-rc4.orig/drivers/i2c/muxes/Kconfig 2012-07-21
22:58:29.000000000 +0200
+++ linux-3.6-rc4/drivers/i2c/muxes/Kconfig 2012-09-09 19:20:13.032141164
+0200
@@ -3,7 +3,7 @@
#
menu "Multiplexer I2C Chip support"
- depends on I2C_MUX
+ depends on HAS_IOMEM && I2C_MUX
config I2C_MUX_GPIO
tristate "GPIO-based I2C multiplexer"
--
Jean Delvare
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
