On Thursday 10 February 2005 21:11, Al Viro wrote: > On Thu, Feb 10, 2005 at 07:39:23PM +0100, Blaisorblade wrote: > > First, Al, thanks a lot for succeeding in solving this... I had tried a > > lot of time ago to make sure that O= worked... (I think that -j already > > worked, unless somebody re-broke it after I fixed that). Plus you fix a > > lot of other stuff. > > > > There are (at least) two bugs to fix about this patch, plus some > > comments: > > > > http://user-mode-linux.sourceforge.net/work/current/2.6/2.6.11-rc3-mm1/pa > >tches/cross-build > > > > 1) typo here: "objtre" should be "objtree" > > > > Index: linux-2.6.10/arch/um/kernel/Makefile > > =================================================================== > > > > @@ -50,7 +50,7 @@ > > quiet_cmd_quote2 = QUOTE $@ > > cmd_quote2 = sed -e '/CONFIG/{' \ > > -e 's/"CONFIG"\;/""/' \ > > - -e 'r $(obj)/config.tmp' \ > > + -e 'r $(objtre)/config.tmp' \ > > Where had that come from? The patch I've done is on > ftp://ftp.linux.org.uk/pub/people/viro/UML-kbuild. I don't see that > chunk in there. The closest I can find is > > -QUOTE = 'my $$config=`cat $(TOPDIR)/.config`; $$config =~ s/"/\\"/g ; > $$config =~ s/\n/\\n"\n"/g ; while(<STDIN>) { $$_ =~ s/CONFIG/$$config/; > print $$_ }' +QUOTE = 'my $$config=`cat $(objtree)/.config`; $$config =~ > s/"/\\"/g ; $$config =~ s/\n/\\n"\n"/g ; while(<STDIN>) { $$_ =~ > s/CONFIG/$$config/; print $$_ }' > > quiet_cmd_quote = QUOTE $@ > cmd_quote = $(PERL) -e $(QUOTE) < $< > $@ > > targets += config.c > -$(obj)/config.c : $(src)/config.c.in $(TOPDIR)/.config FORCE > +$(obj)/config.c : $(src)/config.c.in $(objtree)/.config FORCE > > Note that it's not -mm-based; problem with porting to -mm, maybe? No, porting to the Jeff's tree, I guess now - it's on top of another patch not yet in -mm. > Or > I might have equivalent typo in one of the older versions of patch and > it migrated... > > BTW, that chunk in your patch looks bogus regardless of typos - you have > config.tmp in clean-files, so it'd better be in arch/um/kernel, not in > the root... Jeff, please fix it.
-- Paolo Giarrusso, aka Blaisorblade Linux registered user n. 292729 http://www.user-mode-linux.org/~blaisorblade ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
