On Friday 22 April 2005 03:32, Jeff Dike wrote: > On Wed, Apr 06, 2005 at 03:27:50PM +0200, Bodo Stroesser wrote: > > Here are the patches (tarball attached), that I've applied to > > UML 2.6.11 + incrementals, before adding s390-files. > > These patches are tested a bit on x86, but not on x86_64. > > The COMMAND_LINE_SIZE patch was required because this was conflicting with > the userspace s390 COMMAND_LINE_SIZE? I think this is true because in the > kernel, asm-s390/setup.h doesn't get pulled in. > > This stems from the fact that my tree had add_arg in os-Linux/util.c, which > seems wrong. Blaisorblade had it moved to um_arch.c, which is right, and > where it is in my tree now. So, I think UML_COMMAND_LINE_SIZE is not > needed, and I've removed it. The patch moving add_arg() was *before* the os-* work, so you might move (if needed, which I don't know) it again to os-Linux/util.c if you want (which didn't exist at that time). It came from arch/um/kernel/user_util.c, in fact.
Btw, many of the code movement things are just cut'n'paste things, so for them there is no reason to delay them. Now we are going to merge them for 2.6.13-rc1 (for .12 it's too late), but every other delay increases the possibility that we fix somehow the code we are moving and forget to do the same on the moved code. Finally, about the syscall table patches for s390: I'm going to merge into -mm the syscall table patches you can find in the last -devel snapshot I put on my page (the uploaded ones maybe are out-of-date, but I'll cc you on patches). They entirely remove the UML syscall table to replace it with the $(SUBARCH) one (there is some hand-work to do for each subarch but it's much less than before). While doing this I also fixed various little bugs about this subject. -- Paolo Giarrusso, aka Blaisorblade Skype user "PaoloGiarrusso" Linux registered user n. 292729 http://www.user-mode-linux.org/~blaisorblade ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
