On Thursday 23 June 2005 03:12, Jeff Dike wrote: > On Thu, Jun 23, 2005 at 02:38:35AM +0200, Blaisorblade wrote: > > Would you start preparing a SKAS0 patch-set that I can merge into -bs for > > general testing and that can be merged into -mm at least?
> I'm working on it. skas0 and skas0-clone are the first to go. I just > "fixed" skas0 so it gets mm->nr_ptes right without the change to > exit_mmap that used to be there. I'm banging on that patch now. > The rest still need work. The setup patches (where we make proc_mm et > al settable on the command line and all combinations will work) are > probably OK. Yes, I agree on that too. > Some of the later ones are pretty sad. The ldt patches are probably > not too hard to clean up, but things like add-gate-vma are horrible. "Not touching mainline" is not the main purpose, the problem is doing it cleanly. Honestly I don't know what you're talking about because I've not had the chance to look anyhow at the code. > I'm not planning on having a whole good set before starting to send > them to Andrew. I'll send the ones I'm happiest about, and clean up > the rest, sending them in during the course of 2.6.13. Well, if SKAS0 works without them, it's still ok, though I suspect removing some patches will hurt SKAS0 stability. > > I'd like it to be verifiably "don't touch" about SKAS3 working (i.e. no > > "little changes which won't hurt"). As I already said, I don't mean from > > the "code" viewpoint but from the "what's actually done" viewpoint (in > > terms of strace output, if you want so). > That's a good goal, but we can't let it get in the way of keeping the > code clean. Certainly, anything which touches skas3 should be > carefully looked at, but I don't want to state that we will not touch > any skas3 code. Bodo's patches which make any combination of > PTRACE_LDT, PTRACE_FAULTINFO, and /proc/mm work are a good example. I > think that's a worthwhile patch, but it does touch skas3 code. I specified "operations done on the host" exactly for this purpose. That patch will touch SKAS3 code, but if I set all three options to "yes" the code should do the same things (again, in terms of strace output). But however, if to keep the code clean we change (let's say) where a certain signal handler is set to later in the boot process, *hoping* that it does not hurt, that's against my definition. -- Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!". Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894) http://www.user-mode-linux.org/~blaisorblade ___________________________________ Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB http://mail.yahoo.it ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
