On Tuesday 04 October 2005 19:24, Al Viro wrote: > Taking clone.c to sys-*, making it a normal kernel object, trimming > stub.h This deserves a bit more attention.
In fact, it is a possible fix to a misassembling problem - the current code loads registers in one asm() statement and expects them to be left unaltered in subsequent ones, which sometimes breaks. But currently it breaks things, as this clone.c must be totally self-contained (it doesn't run in the kernel address space - think of vsyscall.S). Btw, do you ever try booting UML? Seems not always, at least... And "static int errno" isn't enough - it must be placed in the data section of the stub, but I don't want to address this for 2.6.14 (even because we are creating a new address space and I don't want to deal with stack lifecycles right now). In fact, I've put together another patch for this, partly copying unistd.h macros. For your patch, we must resolve the errno problem first. Also, making clone.c a kernel object is not conceptually right, because it is actually host-kernel specific (yes, we haven't ports to other host kernels, for now). -- Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!". Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894) http://www.user-mode-linux.org/~blaisorblade ___________________________________ Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB http://mail.yahoo.it ------------------------------------------------------- This SF.Net email is sponsored by: Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
