On Wednesday 18 January 2006 02:12, Greg KH wrote: > > From: Jeff Dike <[EMAIL PROTECTED]>, Paolo 'Blaisorblade' Giarrusso > > <[EMAIL PROTECTED]> > > > > Define a release method for the ubd and network driver so that sysfs > > doesn't complain when one is removed via:
> What? No. The kernel is complaining for a reason, don't try to > out-smart it. I'm not trying to ignore the warning. > > host $ uml_mconsole <umid> remove <dev> > > Done by Jeff around January for ubd only, later lost, then restored in > > his tree - however I'm merging it now since there's no reason to leave > > this here. > > We don't need to do any cleanup in the new added method, because when > > hot-unplug is done by uml_mconsole we already handle cleanup in mconsole > > infrastructure, i.e. mc_device->remove (net_remove/ubd_remove), which is > > also the calling method. > Huh? You have 2 different release functions for the same object? Not sure which ones you refer. net_remove and ubd_remove are for different devices; mc_device->remove and the sysfs release are in different layers and for different things. > And > how do you know which one is correct? That does not sound right at all. No, but since we don't have plugs, we get configuration requests to remove devices. And currently, since this existed in already 2.4, the handler of the configuration request(mc_device->remove) does all the work to shutdown the interface, and then calls into the kobject stuff (with platform_device_unregister()); and this complains for the missing ->remove. If it's better, we may try to move things inside the sysfs ->remove event, with care because different stuff has been done. However, there are a lot of things to look at here... is there anything in ubd_remove() smelling awful? Because we have a crash which is caused by us harming sysfs data structures, which triggers on ubd_remove(). Bug report: http://marc.theaimsgroup.com/?l=user-mode-linux-devel&m=113537479514679&w=2 investigations: http://marc.theaimsgroup.com/?l=user-mode-linux-devel&m=113538805406552&w=2 > Please fix this correctly. -- Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!". Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894) http://www.user-mode-linux.org/~blaisorblade ___________________________________ Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB http://mail.yahoo.it ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642 _______________________________________________ User-mode-linux-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
