On Fri, Apr 07, 2006 at 06:52:05PM +0200, Mattia Dongili wrote: Dear all, > > > > #define UML_LIB_PATH ":/usr/lib/uml" > > > > > what about a config option instead? CONFIG_UML_NET_PATH > > > > Don't think so, that's not supposed to be changed according to any config > > option or I can't see that. Unless on 64-bit system that's /usr/lib64/uml, > > and in that case it makes sense to have CONFIG_XXX = > > "/usr/lib/uml" (without :, add them only in the source, i.e. insulate > > details > > away). > > Yes, that was what I meant. However it's probably not worth the effort > yet. > > > > > 19 -> strlen(UML_LIB_PATH) > > > > in snprintf, "PATH=%s:/usr/lib/uml" -> "PATH=%s" UML_LIB_PATH > > > > > > > > (using string literal concatenation) > > > > > here's an updated patch, I added a check for current PATH=="" to avoid > > > touching the PATH variable when empty (again, kind of keeping the same > > > behaviour of a clean execvp, I mean it makes no sense to append > > > /usr/lib/uml and not /bin:/usr/bin too). > > > > In that case, you should append both IMHO - empty PATH and no PATH should > > be > > treated the same way, I think. > > updated patch attached, I hope you like the if-statement . > > Description: > append /usr/lib/uml to the existing PATH environment variable to let > execvp search uml_net in FHS compliant locations. at this point, is it the case to have also this patch for the uml-utilities in order to install uml-net directly on the FHS complaint path (uml-net):
--- uml_net/Makefile 2003-02-08 05:04:55.000000000 +0100 +++ uml_net/Makefile 2006-04-09 12:48:27.000000000 +0200 @@ -3,7 +3,7 @@ BIN = uml_net CFLAGS = -g -Wall $(TUNTAP) -BIN_DIR ?= /usr/bin +BIN_DIR ?= /usr/lib/uml OBJS = ethertap.o host.o output.o slip.o uml_net.o What do you think? Cheers SteX -- Stefano Melchior, GPG key = D52DF829 - <[EMAIL PROTECTED]> http://etinarcadiaego.dyndns.org -- http://www.stex.name Skype ID "stefanomelchior"
signature.asc
Description: Digital signature
