On martedì 1 maggio 2007, Jeff Dike wrote: > [ Paolo - could you eyeball the globally valid MAC piece of this and > see if you think it's OK? ]
Done, the patch can be accepted (I've not looked at the PCAP part). I've a note on the other fix there (the additional return). > Some network device cleanup. > > When setup_etheraddr found a globally valid MAC being assigned to an > interface, it went ahead and used it rather than assigning a random > MAC like the other cases do. This isn't really an error like the > others, but it seems consistent to make it behave the same. Fine, agreed. For this, you can add my Acked-by. Probably at that time MAC randomization wasn't implemented. > We were getting some duplicate kfree() in the error case in > eth_configure because platform_device_unregister frees buffers that > the error cases following tried to free again. This is due to patch: "uml: drivers get release methods" this could be useful to check whether other such changes are needed, by grepping for platform_device_unregister in exit paths, also for ubd driver. That patch only fixed net_remove() and ubd_remove(). -- Inform me of my mistakes, so I can add them to my list! Paolo Giarrusso, aka Blaisorblade http://www.user-mode-linux.org/~blaisorblade ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
