> cachemiss_thread should explicitly return 0 or error instead of > task_ret_reg(current) (which is -ENOSYS anyway) because > async_thread_helper is careful to put the return value in eax anyway.
Can you explain what motivated you to send out this patch? It used to return 0. It was changed because, unlike the syslet syscalls, sys_io_submit() doesn't have a simple 0 value to indicate success. The current implementation wants to return the number of iocbs that were processed, including the one which blocked, from the cachemiss thread. So before calling into an operation it sets task_ret_ret() so that the cachemiss thread can return it if it takes over. task_ret_reg() is holding a return value that is being returned by the cachemiss thread on behalf of a sys_io_submit() which blocked. When I made the change I didn't really audit its effect on the other paths. I suppose it's time to do that, and you could help by telling me if you saw something bad happen :). - z ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
