On Tue, Jun 19, 2007 at 12:57:07PM -0700, Randy Dunlap wrote:
> Kconfig help text is indented 2 more spaces (by convention or
> CodingStyle).

OK, will fix.

> > +           if(*p != 0)
> 
>               if (*p != NULL)

p is int *, so that's a int version pointer comparision.

> or
>               if (*p)

Conceptually, p is an int, not a boolean, so I prefer to type the
extra characters to do the int-to-boolean conversion in places that
want booleans.

> > +   if (left < lowest_to_date) {
> > +           printk("Greatest stack depth - %d bytes left\n", left);
> 
> Does UML need/use KERN_* facility levels in printk() calls?

Yes, will fix.

                                Jeff

-- 
Work email - jdike at linux dot intel dot com

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Reply via email to