On Tue, Jun 26, 2007 at 01:35:50PM -0700, Andrew Morton wrote: > > sprintf(title, data->title, data->device); > > - pid = run_helper(NULL, NULL, argv, NULL); > > + pid = run_helper(NULL, NULL, argv); > > if (pid < 0) { > > err = pid; > > printk(UM_KERN_ERR "xterm_open : run_helper failed, " > > Something's gone wrong here. My copy of this file has > > pid = run_helper(NULL, NULL, argv, &stack);
Looks like you're applying patches out of order. This is from the 14th, while a patch from the 13th ("UML - xterm driver tidying") has - pid = run_helper(NULL, NULL, argv, &stack); ... + pid = run_helper(NULL, NULL, argv, NULL); If you don't want to fiddle with this, just drop it and I'll rediff against the next -mm and resend. Jeff -- Work email - jdike at linux dot intel dot com ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel