On Sun, Oct 28, 2007 at 03:38:43PM +0800, WANG Cong wrote:
> This patch contains varied fixes and improvements for some files under
> arch/um/os-Linux/, such as a typo fix in a perror message, a missing
> argument fix for a printf, some constifying for pointers and so on.
Generally looks good, thanks.
> printf("failed to install handler for signal %d - errno = %d\n",
> - errno);
> + sig, errno);
Nice spotting - I wonder why gcc didn't complain about this.
> - sigprocmask(on ? SIG_UNBLOCK : SIG_BLOCK, &sigset, &old);
> + if (sigprocmask(on ? SIG_UNBLOCK : SIG_BLOCK, &sigset, &old) < 0)
> + return -1;
In cases like this, I return -errno, not -1. I'll fix this up.
Jeff
--
Work email - jdike at linux dot intel dot com
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
