On Sat, Dec 06, 2008 at 01:02:16AM +0000, Américo Wang wrote:
> On Wed, Dec 3, 2008 at 1:40 PM, Johannes Weiner <[EMAIL PROTECTED]> wrote:
> > On Wed, Dec 03, 2008 at 12:32:02PM +0000, Américo Wang wrote:
> >> On Wed, Dec 3, 2008 at 1:20 AM, Johannes Weiner <[EMAIL PROTECTED]> wrote:
> >> > On Tue, Dec 02, 2008 at 10:51:09PM +0000, Américo Wang wrote:
> >> >> UML implementation of kernel_execve() should not have const qualifier,
> >> >> because it will finally call do_execve() which doesn't have.
> >> >
> >> > And you made sure that do_execve() is correctly annotated?
> >> >
> >>
> >> Yes, I checked that.
> >
> > Good. Then please fix up do_execve() or let the warning stand out as
> > a reminder.
>
> ??
> Confused...
>
> do_execve() is OK, we don't need to fix it.
I don't see where it writes through @filename. So it seems the right
fix would be to make do_execve()s parameter const (and as it seems, a
lot more adjustments down this call graph) and not remove a correct
const from a callsite.
Hannes
------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you. Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
