On Tue, Apr 20, 2010 at 06:09:49PM +0800, Amerigo Wang wrote: > On Mon, Apr 19, 2010 at 11:53:06PM +0200, Jan Kiszka wrote: > >We can't pull in linux/sched.h, so just declare the struct. > > > > Did you meet any build error? If yes, please include it.
What does this patch fix, aside from being a bit cleaner? If it built before, without having a task_struct declaration, I think that means that the elf_core_copy_fpregs was never used. The task_struct * in the declaration would become a private task_struct, known only to the declaration. If the implementation or callers have the regular task_struct, it will be a different one, and the prototypes will conflict due to the different types of the first parameter. Jeff -- Work email - jdike at linux dot intel dot com ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel