On Thu, Jul 21, 2011 at 11:18, Richard Weinberger <rich...@nod.at> wrote:
> Linux can have pids up to 4*1024*1024.
> To handle such huge numbers pid_buf needs to be larger.
>
> Reported-by: Geert Uytterhoeven <ge...@linux-m68k.org>
> Signed-off-by: Richard Weinberger <rich...@nod.at>
> ---
> arch/um/drivers/harddog_user.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/um/drivers/harddog_user.c b/arch/um/drivers/harddog_user.c
> index b56f8e0..84dce3f 100644
> --- a/arch/um/drivers/harddog_user.c
> +++ b/arch/um/drivers/harddog_user.c
> @@ -32,7 +32,7 @@ int start_watchdog(int *in_fd_ret, int *out_fd_ret, char
> *sock)
> {
> struct dog_data data;
> int in_fds[2], out_fds[2], pid, n, err;
> - char pid_buf[sizeof("nnnnn\0")], c;
> + char pid_buf[sizeof("nnnnnnn\0")], c;
Why not make it handle the full 32-bit? That's just a few bytes extra
on the stack...
> char *pid_args[] = { "/usr/bin/uml_watchdog", "-pid", pid_buf, NULL };
> char *mconsole_args[] = { "/usr/bin/uml_watchdog", "-mconsole", NULL,
> NULL };
> --
> 1.7.6
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
------------------------------------------------------------------------------
5 Ways to Improve & Secure Unified Communications
Unified Communications promises greater efficiencies for business. UC can
improve internal communications as well as offer faster, more efficient ways
to interact with customers and streamline customer service. Learn more!
http://www.accelacomm.com/jaw/sfnl/114/51426253/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
