On Thursday 04 July 2013, Chen Gang wrote:
> --------------------------patch begin----------------------------------
>
> 'asm-generic' need provide necessary configuration checking, if can't
> pass checking, 'asm-generic' shouldn't implement it.
>
> For 'COMPILE_TEST', according to its help contents, 'asm-generic' need
> let it pass configuration checking, and provide related dummy contents
> for it.
>
> Part of 'COMPLE_TEST' help contents in "init/Kconfig":
>
> "...Despite they cannot be loaded there (or even when they load they cannot
> be used due to missing HW support)..."
>
> One sample for using 'COMPILE_TEST':
>
> 'PTP_1588_CLOCK_PCH' in drivers/ptp/Kconfig, which need depend on
> 'HAS_IOMEM'.
Then please submit a patch that adds the 'depends on HAS_IOMEM' line there.
That line was clearly left out by accident.
> Signed-off-by: Chen Gang <gang.c...@asianux.com>
> ---
> include/asm-generic/io.h | 22 ++++++++++++++++++----
> 1 files changed, 18 insertions(+), 4 deletions(-)
>
> diff --git a/include/asm-generic/io.h b/include/asm-generic/io.h
> index d5afe96..301ce80 100644
> --- a/include/asm-generic/io.h
> +++ b/include/asm-generic/io.h
> @@ -303,13 +303,18 @@ static inline void *phys_to_virt(unsigned long address)
> /*
> * Change "struct page" to physical address.
> *
> - * This implementation is for the no-MMU case only... if you have an MMU
> - * you'll need to provide your own definitions.
> + * This for the no-MMU, or no-IOMEM but still try to COMPILE_TEST cases.
> + * if you have an MMU and IOMEM, you'll need to provide your own definitions.
> */
> -#ifndef CONFIG_MMU
> +#if !defined(CONFIG_MMU) || \
> + (!defined(CONFIG_HAS_IOMEM) && defined(CONFIG_COMPILE_TEST))
> static inline void __iomem *ioremap(phys_addr_t offset, unsigned long size)
> {
> +#if !defined(CONFIG_MMU)
> return (void __iomem*) (unsigned long)offset;
> +#else
> + return NULL;
> +#endif
> }
>
> #define __ioremap(offset, size, flags) ioremap(offset, size)
This is wrong for multiple reasons, all of which have been discussed in
this thread before.
NAK
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
