On Sat, Aug 17, 2013 at 9:44 AM, <st...@nixia.no> wrote:
> Den 2013-08-16 21:44, skrev Richard Weinberger:
>> +long probe_kernel_read(void *dst, const void *src, size_t size)
>> +{
>> + void *psrc = (void *)rounddown((u64)src, PAGE_SIZE);
> Should not size be increased if psrc is moved down?
>
> Example:
> src = 0x0ffff; // pointed to the very end of a page
> size = 2; // big enough to cross two pages
>
> psrc = 0x0f000; // pointed to the start of the first page
> size = 2; // does not include the second page anymore
>
> second page is not checked
>
> Or is this not a problem?
Good catch, it is of course a problem!
My test cases did all pass because size is always smaller than PAGE_SIZE
and mincore() with at PAGE_SIZE granularity. :-\
--
Thanks,
//richard
------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead.
Download for free and get started troubleshooting in minutes.
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
