Hi Richard, On Sat, May 3, 2014 at 9:12 PM, Richard Weinberger <rich...@nod.at> wrote: > @@ -90,6 +91,9 @@ static int add_mmap(unsigned long virt, unsigned long phys, > unsigned long len, > struct host_vm_op *last; > int fd, ret = 0; > > + if ((virt >= STUB_START) && (virt < STUB_END)) > + return -EINVAL; > +
As you have this exact same check in three different places, I think it's worth splitting it off in a helper function. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ------------------------------------------------------------------------------ Is your legacy SCM system holding you back? Join Perforce May 7 to find out: • 3 signs your SCM is hindering your productivity • Requirements for releasing software faster • Expert tips and advice for migrating your SCM now http://p.sf.net/sfu/perforce _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel