>                  nsecs = timer.it_value.tv_sec *
>                      UM_NSEC_PER_SEC +
>                      timer.it_value.tv_usec *
>                      UM_NSEC_PER_USEC;
>                  nsecs += os_nsecs();

Not looking at the rest of the code, the first thing that comes to my 
mind is that this very easy overflows if 32 bit multiplications are used 
(tv_sec is usually 32bit and dictates the first multiplication unless 
typecast is used).

Stian Skjelstad

------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Reply via email to