Hi David,
On Mon, Jul 13, 2015 at 4:57 PM, David Binderman <dcb...@hotmail.com> wrote:
> Hello there Geert,
>
> ----------------------------------------
>> In that case we feel obliged to guide you to a proper patch submission.
>>
>> Please give it a try. We won't bite ;-)
>
> Since you've been so nice about it, here is my umpteenth go at a
> linux kernel patch.
Thanks for your patch!
As Jeff already commented, you should include a proper patch description.
> Signed-off-by: David Binderman <dcb...@hotmail.com>
>
> --- linux-4.2-rc2/arch/um/drivers/net_user.c.sav 2015-07-13 15:41:33.2115
> 48852 +0100
> +++ linux-4.2-rc2/arch/um/drivers/net_user.c 2015-07-13 15:42:50.191786525
> +0
> 100
> @@ -254,13 +254,17 @@ char *split_if_spec(char *str, ...)
>
> va_start(ap, str);
> while ((arg = va_arg(ap, char **)) != NULL) {
> - if (*str == '\0')
> + if (*str == '\0') {
> + va_end(ap);
> return NULL;
> + }
> end = strchr(str, ',');
> if (end != str)
> *arg = str;
> - if (end == NULL)
> + if (end == NULL) {
> + va_end(ap);
> return NULL;
> + }
> *end++ = '\0';
> str = end;
> }
Unfortunately the patch is whitespace-damaged.
Did you paste it in a web-based email client?
Do you use git?
If yes, perhaps you can use git-send-email.
Based on http://www.serversmtp.com/en/smtp-hotmail, I would try to
add the following to .gitconfig:
[sendemail]
smtpencryption = ssl
smtpserver = smtp.live.com
smtpuser = your Hotmail account
smtppass = your Hotmail password
smtpserverport = 465
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
