Joe Perches wrote: > On Wed, 2007-08-15 at 19:58 -0400, Dave Jones wrote: >> Signed-off-by: Dave Jones <[EMAIL PROTECTED]> >> >> diff --git a/drivers/infiniband/hw/mlx4/mad.c >> b/drivers/infiniband/hw/mlx4/mad.c >> index 3330917..0ed02b7 100644 >> --- a/drivers/infiniband/hw/mlx4/mad.c >> +++ b/drivers/infiniband/hw/mlx4/mad.c >> @@ -109,7 +109,7 @@ int mlx4_MAD_IFC(struct mlx4_ib_dev *dev, int >> ignore_mkey, int ignore_bkey, >> in_modifier, op_modifier, >> MLX4_CMD_MAD_IFC, MLX4_CMD_TIME_CLASS_C); >> >> - if (!err); >> + if (!err) > > There's more than a few of these (not inspected). > > $ egrep -r --include=*.c "\bif[[:space:]]*\([^\)]*\)[[:space:]]*\;" * > arch/sh/boards/se/7343/io.c: if (0) ; > drivers/atm/iphase.c: if (!desc1) ; > drivers/infiniband/hw/mlx4/mad.c: if (!err); > drivers/isdn/capi/capiutil.c: else if (c <= 0x0f); > drivers/net/tokenring/ibmtr.c: else if (ti->shared_ram_paging == 0xf); /* > No paging in adapter */ > drivers/s390/scsi/zfcp_erp.c: if (status == ZFCP_ERP_SUCCEEDED) ; > /* no further action */ > fs/hostfs/hostfs_user.c: if(attrs->ia_valid & HOSTFS_ATTR_CTIME) ; > net/netfilter/xt_u32.c: if (skb->len < 4 || pos > skb->len - 4); > sound/pci/au88x0/au88x0_synth.c: if (eax == 0) > ;
sounds like an excellent candidate check for checkpatch.pl !!! Cheers, Auke ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ User-mode-linux-user mailing list User-mode-linux-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-user
