> > On that topic, does anyone else think --announcer-enable is redundant?
+1. I think this is the case where a single flag would suffice. On Mon, Jan 25, 2016 at 9:28 AM, Bill Farner <[email protected]> wrote: > There's also 2 flags you need to pass to the executor via the scheduler: > --announcer-enable, --announcer-ensemble. See here for example: > https://github.com/apache/aurora/blob/master/examples/vagrant/upstart/aurora-scheduler.conf#L43 > > On that topic, does anyone else think --announcer-enable is redundant? > > > https://github.com/apache/aurora/blob/master/src/main/python/apache/aurora/executor/bin/thermos_executor_main.py > app.add_option( > '--announcer-enable', > dest='announcer_enable', > action='store_true', > default=False, > help='Enable the ServerSet announcer for this executor. Jobs must > still activate using ' > 'the Announcer configuration.') > > app.add_option( > '--announcer-ensemble', > dest='announcer_ensemble', > type=str, > default=None, > help='The ensemble to which the Announcer should register ServerSets.') > > Even the error message and handling of these args suggests redundancy: > > if options.announcer_enable: > if options.announcer_ensemble is None: > app.error('Must specify --announcer-ensemble if the announcer is > enabled.') > status_providers.append(DefaultAnnouncerCheckerProvider( > options.announcer_ensemble, > options.announcer_serverset_path, > options.announcer_allow_custom_serverset_path > )) > > Seems like we should enable the announcer iff announcer_ensemble is set. > > On Mon, Jan 25, 2016 at 8:08 AM, 卢义 <[email protected]> wrote: > >> Hi, >> >> I am using aurora 0.11 (installed from deb package) with mesos 0.26 on >> ubuntu 14.04.3. >> >> My job file: >> scheduler_proc = Process( >> name="kafka_mesos_scheduler_process", >> cmdline=""" >> cd /usr/local/kafka-mesos >> rm kafka-mesos.properties >> touch kafka-mesos.properties >> echo 'user=root' | tee -a kafka-mesos.properties >> echo 'storage=zk:/mesos-kafka-scheduler' | tee -a kafka-mesos.properties >> echo 'master=zk://ourtmx01:2181,ourtmx02:2181,ourtmx05:2181/mesos' | tee >> -a kafka-mesos.properties >> echo ‘zk=myzkenpoints/kafka02' | tee -a kafka-mesos.properties >> echo 'api=http://0.0.0.0:{{thermos.ports[http]}}' | tee -a >> kafka-mesos.properties >> cat kafka-mesos.properties >> ./kafka-mesos.sh scheduler >> """) >> >> scheduler_task = Task( >> name = 'run_scheduler', >> processes = [scheduler_proc], >> resources = Resources(cpu = 0.5, ram = 512*MB, disk=128*MB)) >> >> jobs = [ >> Service(cluster = ‘mycluster', >> environment = 'prod', >> role = 'root', >> name = 'kafka-mesos', >> task = scheduler_task, >> announce = Announcer(), >> container = Container(docker = Docker(image = >> ‘myregistryserver:5000/kafka-mesos-scheduler:0.9')))] >> >> The job was running well, but I did’t find any ServerSets added to my ZK. >> There are only scheduler and replicated-log in /aurora. >> >> >> >> >
