Thanks Doug. Yes, extra documentation would be good but I think the subclass would be really useful too. I'll file a JIRA and work on a patch for it.
Cheers, Dave On 11 December 2012 17:55, Doug Cutting <[email protected]> wrote: > On Tue, Dec 11, 2012 at 7:11 AM, Dave Beech <[email protected]> wrote: > > What this means is, if you want to use a grouping comparator with the > "new" > > mapreduce API and Avro, you absolutely must provide an implementation of > > RawComparator, or do the deserialization and delegating method call to > > compare(x,y) yourself. This really isn't obvious and I haven't found it > to > > be documented anywhere. > > Sounds like we should at least add some documentation and probably > also make this simpler. Perhaps we could provide a subclass of > AvroKeyComparator that does the deserialization and delegates to > compare(x,y)? Then folks can subclass this and override compare(x,y)? > > Doug >
