On Sat, Nov 3, 2018 at 1:13 AM Brian Spindler <brian.spind...@gmail.com> wrote:
> That wasn't horrible at all. After testing, provided all goes well I can > submit this back to the main TWCS repo if you think it's worth it. > > Either way do you mind just reviewing briefly for obvious mistakes? > > > https://github.com/bspindler/twcs/commit/7ba388dbf41b1c9dc1b70661ad69273b258139da > About almost a year ago we were migrating from 2.1 to 3.0 and we figured out that Jeff's master branch didn't compile with 3.0, but the change to get it running was really minimal: https://github.com/a1exsh/twcs/commit/10ee91c6f409aa249c8d439f7670d8b997ab0869 So we built that jar, added it to the packaged 3.0 and we were good to go. Maybe you might want to consider migrating in two steps: 2.1 -> 3.0, ALTER TABLE, upgradesstables, 3.0 -> 3.1. And huge thanks to Jeff for coming up with TWCS in the first place! :-) Cheers, -- Alex
