Thanks, Keith. Looks like I have been reading that commetn again and again, but failed to notice that this was moved to MappingLoader ... :-(.
Werner > -----Original Message----- > From: Keith Visco [mailto:[EMAIL PROTECTED] > Sent: Mittwoch, 25. Oktober 2006 08:08 > To: Werner Guttmann > Cc: [email protected] > Subject: Re: [castor-user] Is public static {Type} > valueOf(String) not working with 1.0.4? > > > I don't remember exactly, but the comment I added to the code > gives us a clue: > > //-- mapping loader now supports a basic EnumFieldHandler > //-- for xml we simply need to make sure the toString() > //-- method is called during getValue() > //FieldHandler handler = xmlDesc.getHandler(); //handler = > new EnumFieldHandler(fieldType, handler); > > FieldHandler handler = new ToStringFieldHandler(fieldType, > xmlDesc.getHandler()); > > > looking at the code it looks like I moved the basic type-safe > enum handling code to the base MappingLoader, and the > ToStringFieldHandler was needed to support that. So basically > MappingLoader should be handling the type-safe enums directly > now which is why that code change was made. > > --Keith > > Werner Guttmann wrote: > > No, not really. I am just trying to get my head around as > to why this ever worked, as it looks like in > XMLMappingLoader.createFieldDesc() the working code (using an > EnumFieldHandler) was commented out with SVN version 5272 > (back in March 2005 by Keith). > > > > For those of my peer committers that listen in, can anybody > tyr to answer the following question: > > > > Why (at lines 589ff of XMLmappingLoader, SVN trunk) has the > instantiation of EnumFieldHandler been commented out ? > > > > Werner > > > >> -----Original Message----- > >> From: M.-Leander Reimer [mailto:[EMAIL PROTECTED] > >> Sent: Dienstag, 24. Oktober 2006 15:24 > >> To: [email protected] > >> Subject: AW: [castor-user] Is public static {Type} > >> valueOf(String) not working with 1.0.4? > >> > >> Hi, > >> > >> The error message is kind of the same indeed. The only > difference is > >> that the test case uses pure Java enums and in my case I have > >> enum-style classes. > >> > >> @Werner: > >> Should I open a new issue, just attach my unit tests to > Henk's issue > >> (http://jira.codehaus.org/browse/CASTOR-1653), > >> or do nothing? > >> > >> Leander > >> > >> ________________________________________ > >> Von: [EMAIL PROTECTED] > >> [mailto:[EMAIL PROTECTED] > >> Gesendet: Dienstag, 24. Oktober 2006 14:10 > >> An: [email protected] > >> Betreff: RE: [castor-user] Is public static {Type} > >> valueOf(String) not working with 1.0.4? > >> > >> > >> I encountered the same problem. I have a small test case that > >> illustrates the problem. > >> > >> Posted an issue as http://jira.codehaus.org/browse/CASTOR-1653 > >> > >> Met vriendelijke groet / With kind regards Henk van Voorthuijsen > >> Software Engineer > >> e-mail: [EMAIL PROTECTED] > >> phone: +31 (0) 1 82 69 19 19 > >> > >> ACI WorldWide bv > >> Smart Card Division, Solutions & Services > >> Antwerpseweg 1 / 2803 PB Gouda > >> PO BOX 867 / 2800 AW Gouda > >> The Netherlands > >> phone: +31 (0) 1 82 57 36 00 > >> fax: +31 (0) 1 82 57 35 13 > >> > >> http://www.aciworldwide.com > >> > >> This e-mail message and any attachments may contain confidential, > >> proprietary or non-public information. This information > is intended > >> solely for the designated recipient(s). If an addressing or > >> transmission error has misdirected this e-mail, please notify the > >> sender immediately and destroy this e-mail. Any review, > >> dissemination, use or reliance upon this information by unintended > >> recipients is prohibited. Any opinions expressed in this > e-mail are > >> those of the author personally. > >> > >> > >> > --------------------------------------------------------------------- > >> To unsubscribe from this list please visit: > >> > >> http://xircles.codehaus.org/manage_email > >> > >> > >> > > > > > > > --------------------------------------------------------------------- To unsubscribe from this list please visit: http://xircles.codehaus.org/manage_email
