Hi Ron,
please see inline ....
Werner
Corcuera,Ron wrote:
> Hi Werner,
>
> I got the update on CASTOR-2078. Would you clarify a few things for me?
Sure.
> You mentioned that, "re-generation of classes is a necessity." I can
> understand that. This will not be a problem since, the reason we were
> upgrading was to regenerate the classes anyway.
>
> You also mentioned that, "the XML instance documents will have to be
> altered as well." Would you clarify this for me? My stab at the
> meaning of that is that the newly generated code would not be able to
> "understand" XML documents created by the older code? I'm hoping that
> is wrong.
Yes, this is correct for this one special case you have reported. I am
changing the 'xmlName' property for an anon simple type (more
specifically enumeration) so that it does not include a '-Type' suffix,
as this is wrong. If you already used Castor in the past the generate
classes for such anon simple type definitions (enumerations, again), and
used these classes to marshall XML, post-patch you will not be able to
read them in again without altering the XML.
As clearly this is a bug, we have to introduce this break in one way or
the other. And clearly, I'd rather have a flaw less with Castor, to be
honest.
>
> Also, I saw the patch file that you added to the issue. I'm sorry for
> my ignorance of how Jira works. Does that patch file show what needs to
> be changed to the code so that it would work or does it just show where
> the work will need to be added?
A unified patch file shows exactly the changes that need to be applied
to SVN trunk so that your problem is resolved. In other words, if the
patch is eventually applied to SVN trunk, and the changes committed, all
future releases of Castor will have this issue resolved.
> I looked at the source code for that
> java file in version 1.1.2.1 and it seems that both methods do exactly
> what is outlined in the patch file already.
As already mentioned, you'd have to apply this patch to SVN trunk. In
other words, check out Castor from SVN trunk, apply the patch yourself
and build the binaries. If you are happy with this, I'd ask you to go
ahead and try this yourself and report back your findings. Of course, if
you happen to have questions along the way (as you might not be e.g.
familiar with SVN), we are willing to help. My working assumption is
that you know how to use SVN, checkout a project and apply a patch.
>
> Would you mind explaining what the next step is? I'd like to test the
> proposed changes.
>
> Thanks for your work,
> Ron
>
---------------------------------------------------------------------
To unsubscribe from this list please visit:
http://xircles.codehaus.org/manage_email
