Disregard this message. Upon closer inspection, I can see that the
reported unclosed connections are in fact not being closed. I am not
sure if this was fixed by the upgrade or not, but I took a closer look
at the line numbers in the compiled _jsp.java and they are connections
from an imported page that are not being closed.
Tyson
On 11/12/2010 9:15 AM, Tyson Lowery wrote:
Thanks for the help. Unfortunately, I've made the change to upgrade
and I'm still seeing the issue. I've gone ahead and added some more
debugging info to my code. I'm seeing the issue about 1% of the time
with this test case. I'm outputting debugging information before my
try block, and at the end of my finally block (among other places). A
grep count shows that there are an equal number of these statements in
the catalina.out file over a specific time period, 637. I am checked
how many times this page appeared in the access_log over the same time
period, and it also added up to 637. During this time, it was
reported that 6 connections were not closed by this jsp. I also am
outputting the result of Connection.isClosed() and
Statement.isClosed() to catalina.out after I close the connections and
statements. These always show as true.
Please note that I have other jsps that I know are NOT closing
connections properly. Is it possible that AbandonedTrace.java has a
bug and is reporting the wrong jsp page in the log?
Where should I dig next?
Thanks,
Tyson
On 11/11/2010 1:08 PM, Mark Thomas wrote:
On 11/11/2010 18:57, Tyson Lowery wrote:
Thanks Mark for taking the time to reply.
I've upgraded Tomcat to 6.0.29. Do I still need to explicitly set the
factory to make sure I'm using DBCP 1.3?
Maybe. 6.0.29 ships with DBCP 1.3 and Pool 1.5.4. To get the benefits of
Pool 1.5.5 you'd need to follow the instructions below.
6.0.30 will include Pool 1.5.5
Mark
On 11/11/2010 12:37 AM, Mark Thomas wrote:
On 11/11/2010 05:11, Phil Steitz wrote:
I will check or someone else can confirm DBCP and pool versions.
http://svn.apache.org/viewvc/tomcat/tc6.0.x/tags/TOMCAT_6_0_26/build.properties.default?view=markup
DBCP 1.2.2
Pool 1.5.4
If not the latest you can upgrade them independently of Tomcat and
you should try that. See the Tomcat datasource docs for instructions
on how to do this. Ask here or on tomcat-user if you need help.
1. Add latest DBCP& Pool JARs to CATALINA_BASE/lib
2. Modify your Resource to include:
factory="org.apache.commons.dbcp.BasicDataSourceFactory"
3. Restart
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
