On 7 December 2012 18:20, Gary Gregory <[email protected]> wrote: > On Fri, Dec 7, 2012 at 1:19 PM, sebb <[email protected]> wrote: > >> On 7 December 2012 15:49, Ari Fainchtein <[email protected]> wrote: >> > Thanks for the answer. I actually just found the problem. I removed >> the line >> > >> > ftpClient.setFileTransferMode(FTP.BINARY_FILE_TYPE); >> > >> > and that made it work. It was wrong, since the parameter was not correct. >> >> Actually, this line is wrong too: >> >> ftpClient.setFileType(FTP.BINARY_FILE_TYPE, FTP.BINARY_FILE_TYPE); >> >> The second parameter should either be omitted, or it should be one of >> the _FORMAT constants. >> >> Unfortunately the parameters are ints rather than enums so the >> compiler cannot generate an error if you use the wrong one. >> > > How about adding enums and deprecating this error prone API for the next > release?
Not sure it's possible without breaking binary compatibility. And there is some overlap between the modes. However this is a discussion for the developer list, at least initially. > Gary > > >> > >> > On 08/12/2012, at 2:42 AM, sebb wrote: >> > >> >> On 7 December 2012 14:16, Ari Fainchtein <[email protected]> wrote: >> >>> Hello, >> >>> >> >>> I am trying to use the FTPClient to upload files and everything is >> working fine except that the files arrive all garbled to the server. I >> have tried with pdfs and jpegs and in both case the files are corrupted. >> >>> >> >>> Any help would be appreciated. >> >>> >> >> >> >> Try using the FTP client example [1] to upload the file. >> >> If that works, see how it differs from your code. >> >> >> >> [1] http://commons.apache.org/net/examples/ftp/FTPClientExample.java >> >> >> >> --------------------------------------------------------------------- >> >> To unsubscribe, e-mail: [email protected] >> >> For additional commands, e-mail: [email protected] >> >> >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> > > > -- > E-Mail: [email protected] | [email protected] > JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 > Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
