Hi Thejas and Jordan, If the blockUntilConnected method is an internal API that was inadvertently made public, wouldn't it be more proper to deprecate the method? Does the curator project have an established policy for deprecation/removal of functionality?
-Stephen From: Jordan Zimmerman <[email protected]<mailto:[email protected]>> Reply-To: "[email protected]<mailto:[email protected]>" <[email protected]<mailto:[email protected]>> Date: Wednesday, October 29, 2014 at 3:27 PM To: Thejas Nair <[email protected]<mailto:[email protected]>> Cc: Vaibhav Gumashta <[email protected]<mailto:[email protected]>>, "[email protected]<mailto:[email protected]>" <[email protected]<mailto:[email protected]>> Subject: Re: blockUntilConnected use Sure - if you don't mind, please provide a pull request with the change. On October 29, 2014 at 5:26:35 PM, Thejas Nair ([email protected]<mailto:[email protected]>) wrote: Thanks for the clarification Cameron and Jordan. I don't see anywhere in the documentation which says that it should be used before Curator calls. But its presence in CuratorFramework as a public method makes one wonder, if that is a public function in that class for a reason. I think it will be useful to have a comment in the functions javadoc to say that is for some very specific recipes, and it does not have to be called before using the other functions in CuratorFramework class. Thoughts ? On Wed, Oct 29, 2014 at 3:15 PM, Jordan Zimmerman <[email protected]<mailto:[email protected]>> wrote: > That's an internal method. Any of the Curator Framework methods will call it > to make sure the connection is valid. You should never need to call it > yourself. > > -Jordan > > > On October 29, 2014 at 5:04:58 PM, Thejas Nair > ([email protected]<mailto:[email protected]>) > wrote: > > When is CuratorFramework.blockUntilConnected supposed to be used ? It > is not clear if one should call that before a create or getData. > > After digging some more into the jira that added that and the code > base, I believe that calling it is not necessary before invoking other > CuratorFramework functions. Having to do that would be contrary to the > goals of curator. > > Should we document that it is not necessary to call > blockUntilConnected before invoking other operations in > CuratorFramework? > > Thanks, > Thejas > > -- > CONFIDENTIALITY NOTICE > NOTICE: This message is intended for the use of the individual or entity to > which it is addressed and may contain information that is confidential, > privileged and exempt from disclosure under applicable law. If the reader > of this message is not the intended recipient, you are hereby notified that > any printing, copying, dissemination, distribution, disclosure or > forwarding of this communication is strictly prohibited. If you have > received this communication in error, please contact the sender immediately > and delete it from your system. Thank You. -- CONFIDENTIALITY NOTICE NOTICE: This message is intended for the use of the individual or entity to which it is addressed and may contain information that is confidential, privileged and exempt from disclosure under applicable law. If the reader of this message is not the intended recipient, you are hereby notified that any printing, copying, dissemination, distribution, disclosure or forwarding of this communication is strictly prohibited. If you have received this communication in error, please contact the sender immediately and delete it from your system. Thank You.
