All PRs first undergo code review, even doc updates. Then PRs are merged by the Apache committer.
Kind regards, Arina On Thu, Oct 11, 2018 at 10:17 AM Divya Gehlot <[email protected]> wrote: > Hi Arina, > > Just to clarify If I create the pull request it will automatically gets > publish to https://drill.apache.org/docs/logfile-plugin/ , there is no > need update the docs? > > Thanks, > Divya > > On Mon, 8 Oct 2018 at 15:40, Arina Yelchiyeva <[email protected]> > wrote: > > > Hi Divya, > > > > You can create PR for docs update. Charles and Bridget can review it. > > Example of the PR - https://github.com/apache/drill/pull/1479 < > > https://github.com/apache/drill/pull/1479> > > > > Kind regards, > > Arina > > > > > On Oct 8, 2018, at 9:45 AM, Divya Gehlot <[email protected]> > > wrote: > > > > > > Thank you so much Paul ! > > > It worked perfectly :) > > > Can I be help in updating the docs ? Let me know . > > > I am not sure whether I have the permission to do so . > > > > > > Thanks, > > > Divya > > > > > > On Thu, 4 Oct 2018 at 22:53, Charles Givre <[email protected]> wrote: > > > > > >> Hi Divya, > > >> Good catch. These docs are for an earlier version of this plugin that > > >> didn’t make it into Drill. Here are correct docs: > > >> > > >> > > >> > > > https://github.com/cgivre/drill/blob/24556d857cbbe7aa2baa1fc6cbd85fb614b5d975/exec/java-exec/src/main/java/org/apache/drill/exec/store/log/README.md > > >> < > > >> > > > https://github.com/cgivre/drill/blob/24556d857cbbe7aa2baa1fc6cbd85fb614b5d975/exec/java-exec/src/main/java/org/apache/drill/exec/store/log/README.md > > >>> > > >> > > >> You’ll find that the newer version is A LOT easier to use than that! > > >> > > >> > > >> @Bridget, could you please take a look at this and update the docs? > > >> Thanks! > > >> > > >> > > >>> On Oct 4, 2018, at 01:09, Divya Gehlot <[email protected]> > > wrote: > > >>> > > >>> Hi, > > >>> I am using Drill 1.14 and followed these instructions > > >>> <https://drill.apache.org/docs/logfile-plugin/>to read log files of > > any > > >>> format in drill. > > >>> > > >>> When I insert the log plugin in the storage plugin , it is > complaining > > >> that > > >>> its is not valid JSON , though I already verified it through JSON > > >>> validator and it seems to be correct . > > >>> Pasted the storage plugin here <https://pastebin.com/ATWxHFqQ> > > >>> > > >>> Thanks, > > >>> Divya > > >> > > >> > > > > >
