Built it from cloning the git branch and unit tests on my Linux VM (time taken - 43 min). Tested new features of metadata caching by creating v4 cache files using new Refresh Metadata commands and manually verified the cache files. Tried a few queries that use metadata cache and verified results.
The release looks good to me +1. Thank you, Jyothsna [image: Mailtrack] <https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5&;> Sender notified by Mailtrack <https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5&;> 04/24/19, 12:09:52 AM On Wed, Apr 24, 2019 at 12:09 AM Jyothsna Reddy <jyothsna....@gmail.com> wrote: > Built it from cloning the git branch and unit tests on my Linux VM (time > taken - 43 min). > Tested new features of metadata caching by creating v4 cache files using > new Refresh Metadata commands and manually verified the cache files. Tried > a few queries that use metadata cache and verified results. > Did a few manual tests with REFRESH METADATA by creating the new V4 > > The release looks good to me +1. > > Thank you, > Jyothsna > > On Tue, Apr 23, 2019 at 1:56 PM Sorabh Hamirwasia <shamirwa...@mapr.com> > wrote: > >> Hi Volodymyr, >> The KEYS file on svn will be updated when a release candidate is approved >> and all the artifacts are copied to the svn. >> >> NOTICE is not updated per release so I won't treat it as blocker. But >> would >> be good to add it in the wiki below to ensure from next time onwards it's >> updated. >> >> For release I am following this wiki[1] which is part of Parth's >> repository. I will update it to include both the steps above as well. >> >> [1]: https://github.com/parthchandra/drill/wiki/Drill-Release-Process >> >> Thanks, >> Sorabh >> >> On Tue, Apr 23, 2019 at 1:19 PM Volodymyr Vysotskyi <volody...@apache.org >> > >> wrote: >> >> > Sorabh, could you please add your key to the >> > https://dist.apache.org/repos/dist/release/drill/KEYS file? >> > >> > Not sure that it is a blocker, but the year in NOTICE is 2018. >> > >> > Do we have any guides for basic checks for release? If no, it would be >> good >> > to introduce such a list of things to check for the release manager. >> > >> > Kind regards, >> > Volodymyr Vysotskyi >> > >> > >> > On Tue, Apr 23, 2019 at 11:09 PM Aman Sinha <amansi...@apache.org> >> wrote: >> > >> > > Downloaded source tarball on my Linux VM and built and ran unit tests >> > > successfully (elapsed time 46 mins). >> > > Downloaded binary tarball on my Mac and ran in embedded mode. >> > > Verified Sorabh's release signature using gpg --verify >> > > Checked the maven artifacts are published >> > > Checked Ran a few queries against TPC-DS SF1 and examined query >> profiles >> > in >> > > the Web UI. Looked good. >> > > Did a few manual tests with REFRESH METADATA by creating the new V4 >> > > metadata cache and checked EXPLAIN plans and query results. >> > > Found an issue with control-c handling and filed DRILL-7198 and >> noted in >> > > the JIRA that I don't think it is a blocker. >> > > >> > > Overall, release looks good ! +1 >> > > >> > > Aman >> > > >> > > >> > > On Tue, Apr 23, 2019 at 10:01 AM SorabhApache <sor...@apache.org> >> wrote: >> > > >> > > > Thanks Aman and Volodymyr for discussing on this issue. Just to >> clarify >> > > on >> > > > the thread that RC1 still stands as valid, since the issue is not >> > blocker >> > > > anymore. >> > > > >> > > > On Tue, Apr 23, 2019 at 9:18 AM Volodymyr Vysotskyi < >> > > volody...@apache.org> >> > > > wrote: >> > > > >> > > > > Discussed with Aman and concluded that this issue is not a blocker >> > for >> > > > the >> > > > > release. >> > > > > >> > > > > Kind regards, >> > > > > Volodymyr Vysotskyi >> > > > > >> > > > > >> > > > > On Tue, Apr 23, 2019 at 6:39 PM Aman Sinha <amansi...@gmail.com> >> > > wrote: >> > > > > >> > > > > > Hi Vova, >> > > > > > I added some thoughts in the DRILL-7195 JIRA. >> > > > > > >> > > > > > Aman >> > > > > > >> > > > > > On Tue, Apr 23, 2019 at 6:06 AM Volodymyr Vysotskyi < >> > > > > volody...@apache.org> >> > > > > > wrote: >> > > > > > >> > > > > > > Hi all, >> > > > > > > >> > > > > > > I did some checks and found the following issues: >> > > > > > > - DRILL-7195 < >> https://issues.apache.org/jira/browse/DRILL-7195> >> > > > > > > - DRILL-7194 < >> https://issues.apache.org/jira/browse/DRILL-7194> >> > > > > > > - DRILL-7192 < >> https://issues.apache.org/jira/browse/DRILL-7192> >> > > > > > > >> > > > > > > One of them (DRILL-7194) is also reproduced on the previous >> > > version, >> > > > > > > another is connected with the new feature (DRILL-7192), so I >> > don't >> > > > > think >> > > > > > > that we should treat them as blockers. >> > > > > > > The third one (DRILL-7195) is a regression and in some cases >> may >> > > > cause >> > > > > > the >> > > > > > > wrong results, so I think that it should be fixed before the >> > > release. >> > > > > > > Any thoughts? >> > > > > > > >> > > > > > > Kind regards, >> > > > > > > Volodymyr Vysotskyi >> > > > > > > >> > > > > > > >> > > > > > > On Mon, Apr 22, 2019 at 8:58 PM SorabhApache < >> sor...@apache.org> >> > > > > wrote: >> > > > > > > >> > > > > > > > *< Please disregard previous email, one of the link is not >> > > correct >> > > > in >> > > > > > it. >> > > > > > > > Use the information in this email instead >* >> > > > > > > > >> > > > > > > > Hi Drillers, >> > > > > > > > I'd like to propose the second release candidate (RC1) for >> the >> > > > Apache >> > > > > > > > Drill, >> > > > > > > > version 1.16.0. >> > > > > > > > >> > > > > > > > Changes since the previous release candidate: >> > > > > > > > DRILL-7185: Drill Fails to Read Large Packets >> > > > > > > > DRILL-7186: Missing storage.json REST endpoint >> > > > > > > > DRILL-7190: Missing backward compatibility for REST API with >> > > > > DRILL-6562 >> > > > > > > > >> > > > > > > > Also below 2 JIRA's were created to separately track revert >> of >> > > > > protbuf >> > > > > > > > changes in 1.16.0: >> > > > > > > > DRILL-7188: Revert DRILL-6642: Update protocol-buffers >> version >> > > > > > > > DRILL-7189: Revert DRILL-7105 Error while building the Drill >> > > native >> > > > > > > client >> > > > > > > > >> > > > > > > > The RC1 includes total of 215 resolved JIRAs [1]. >> > > > > > > > Thanks to everyone for their hard work to contribute to this >> > > > release. >> > > > > > > > >> > > > > > > > The tarball artifacts are hosted at [2] and the maven >> artifacts >> > > are >> > > > > > > hosted >> > > > > > > > at [3]. >> > > > > > > > >> > > > > > > > This release candidate is based on commit >> > > > > > > > cf5b758e0a4c22b75bfb02ac2653ff09415ddf53 located at [4]. >> > > > > > > > >> > > > > > > > Please download and try out the release candidate. >> > > > > > > > >> > > > > > > > The vote ends at 06:00 PM UTC (11:00 AM PDT, 09:00 PM EET, >> > 11:30 >> > > PM >> > > > > > IST), >> > > > > > > > Apr 25th, 2019 >> > > > > > > > >> > > > > > > > [ ] +1 >> > > > > > > > [ ] +0 >> > > > > > > > [ ] -1 >> > > > > > > > >> > > > > > > > Here is my vote: +1 >> > > > > > > > [1] >> > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313820&version=12344284 >> > > > > > > > [2] >> > http://home.apache.org/~sorabh/drill/releases/1.16.0/rc1/ >> > > > > > > > [3] >> > > > > > > > >> > > > > > >> > > > >> > https://repository.apache.org/content/repositories/orgapachedrill-1067/ >> > > > > > > > [4] https://github.com/sohami/drill/commits/drill-1.16.0 >> > > > > > > > >> > > > > > > > Thanks, >> > > > > > > > Sorabh >> > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > >> >
