Hi Arina,
Thanks for the note.
I would expand the definition of regression that it worked in one release, and
changed in a later release. The problem is, we just didn't check in the Drill
1.16 release. Or, we made the change without understanding the impact.
In this one area, the entire purpose of the sqlTypeOf() function was to return
the name of the type. The existing typeof() did not do so in some cases, which
is why we added sqlTypeOf().
Of course, if there is a good reason for sqlTypeOf() to not return the type
name, then I guess I'll need to add a "realSqlTypeOf()"to do what sqlTypeOf()
was supposed to do.
Having worked in commercial software a long time, I would not suggest doing
minor release for this issue. It really only affects debugging and training,
not production users.
Thanks for pointing out the release manager issue. Our #1 obstacle to that job
is that only CV folks have access to the functional test platform; there is no
way for someone like Charles or I to perform the crucial verification step. I
think we could do most of the other tasks.
Thanks,
- Paul
On Friday, December 27, 2019, 01:18:48 AM PST, Arina Yelchiyeva
<[email protected]> wrote:
Hi Paul,
thanks for verifying the release.
Regression for the release is considered something that worked in previous
version, in our case in 1.16 and stopped working in the released, in our case
case 1.17. Vova has checked both sqltypeof issues, they behave the same in 1.16
so from the release perspective, they are not regressions but bugs. Thus they
won’t have sinked the last release candidate. By the way, one of the issues
actually was a deliberate change in 1.16, I have left comment in Jira.
Regarding minor release, since both issues are not regressions, there is no
point of doing it. Though if they were, I would still say we should not prepare
minor release unless found bugs are something really serious that prevents
Drill from starting. Mostly because release preparation takes time not only for
the release manager but for the PMCs and committers to verify and cast votes.
Actually, it a good time to think when we want to release 1.18 and find
volunteer to be a release manager.
Kind regards,
Arina
> On 27 Dec 2019, at 04:48, Paul Rogers <[email protected]> wrote:
>
> Hi Charles,
>
> Good question! We have a number of big changes queued up. To do a minor
> release, we'd want to branch off of the Drill 1.17 release, which is extra
> work.
>
>
> Let's see if anyone finds other issues we'd like to fix so we can see if the
> effort would be worthwhile.
>
>
> Thanks,
> - Paul
>
>
>
> On Thursday, December 26, 2019, 6:24:27 PM PST, Charles Givre
><[email protected]> wrote:
>
> Paul,
> Do you think it's worth fixing these and releasing a minor release in a month
> or so with this and any other minor bug fixes?
> -- C
>
>> On Dec 26, 2019, at 9:17 PM, Paul Rogers <[email protected]> wrote:
>>
>> Hi All,
>>
>> I'm late to the party (was distracted by a certain holiday). Downloaded the
>> artifacts and ran though the examples in the first several sections of
>> Chapter 8 of the Learning Apache Drill book.
>>
>> It turns out we have a regression in the sqlTypeOf() function. See
>> DRILL-7499 and DRILL-7501.
>>
>> These are minor as they only affect users of the functions. But, the errors
>> cause the results in Drill 1.17 to regress from those in Drill 1.14 (when
>> the book was written.)
>>
>> Otherwise, everything seemed to work fine.
>>
>> Thanks,
>> - Paul
>>
>>
>>
>> On Sunday, December 22, 2019, 9:00:52 AM PST, Volodymyr Vysotskyi
>><[email protected]> wrote:
>>
>> Hi all,
>>
>> I'd like to propose the third release candidate (RC2) of Apache Drill,
>> version 1.17.0.
>>
>> Changes since the previous release candidate: fixed show-stopper DRILL-7494
>> <https://issues.apache.org/jira/browse/DRILL-7494>.
>>
>> The release candidate covers a total of 205 resolved JIRAs [1]. Thanks to
>> everyone who contributed to this release.
>>
>> The tarball artifacts are hosted at [2] and the maven artifacts are hosted
>> at [3].
>>
>> This release candidate is based on
>> commit 2eb6bbe0501cb6553106e63dc1f2810ff10ae375 located at [4].
>>
>> Please download and try out the release.
>>
>> The vote ends at 5 PM UTC (9 AM PDT, 7 PM EET, 10:30 PM IST), December 25,
>> 2019
>>
>> [ ] +1
>> [ ] +0
>> [ ] -1
>>
>> Here's my vote: +1
>>
>> [1]
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313820&version=12344870
>> [2] http://home.apache.org/~volodymyr/drill/releases/1.17.0/rc2/
>> [3] https://repository.apache.org/content/repositories/orgapachedrill-1077/
>> [4] https://github.com/vvysotskyi/drill/commits/drill-1.17.0
>>
>> Kind regards,
>> Volodymyr Vysotskyi
