Thanks Charles! Hope you are recovering well. Please take care. On Tue, Sep 1, 2020 at 5:28 PM Charles Givre <[email protected]> wrote:
> Hey Abhishek, > I’ll take a look tomorrow. > Best, > — C > > > On Sep 1, 2020, at 8:27 PM, Abhishek Girish <[email protected]> wrote: > > > > Thanks Vova! > > > > Hey folks, we need more votes to validate the release. Please give RC0 a > > try. > > > > Special request to PMCs - please vote as we only have 1 binding vote at > > this point. I am fine extending the voting window by a day or two if > anyone > > is or plans to work on it soon. > > > > On Tue, Sep 1, 2020 at 12:09 PM Volodymyr Vysotskyi < > [email protected]> > > wrote: > > > >> Verified checksums and signatures for binary and source tarballs and for > >> jars published to the maven repo. > >> Run all unit tests on Ubuntu with JDK 8 using tar with sources. > >> Run Drill in embedded mode on Ubuntu, submitted several queries, > verified > >> that profiles displayed correctly. > >> Checked JDBC driver using SQuirreL SQL client and custom java client, > >> ensured that it works correctly with the custom authenticator. > >> > >> +1 (binding) > >> > >> Kind regards, > >> Volodymyr Vysotskyi > >> > >> > >> On Mon, Aug 31, 2020 at 1:37 PM Volodymyr Vysotskyi < > [email protected]> > >> wrote: > >> > >>> Hi all, > >>> > >>> I have looked into the DRILL-7785, and the problem is not in Drill, so > it > >>> is not a blocker for the release. > >>> For more details please refer to my comment > >>> < > >> > https://issues.apache.org/jira/browse/DRILL-7785?focusedCommentId=17187629&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17187629 > >>> > >>> on this ticket. > >>> > >>> Kind regards, > >>> Volodymyr Vysotskyi > >>> > >>> > >>> On Mon, Aug 31, 2020 at 4:26 AM Abhishek Girish <[email protected]> > >>> wrote: > >>> > >>>> Yup we can certainly include it if RC0 fails. So far I’m inclined to > not > >>>> consider it a blocker. I’ve requested Vova and Anton to take a look. > >>>> > >>>> So folks, please continue to test the candidate. > >>>> > >>>> On Sun, Aug 30, 2020 at 6:16 PM Charles Givre <[email protected]> > wrote: > >>>> > >>>>> Ok. Are you looking to include DRILL-7785? I don't think it's a > >>>> blocker, > >>>>> but if we find anything with RC0... let's make sure we get it in. > >>>>> > >>>>> -- C > >>>>> > >>>>> > >>>>> > >>>>>> On Aug 30, 2020, at 9:14 PM, Abhishek Girish <[email protected]> > >>>> wrote: > >>>>> > >>>>>> > >>>>> > >>>>>> Hey Charles, > >>>>> > >>>>>> > >>>>> > >>>>>> I would have liked to. We did get one of the PRs merged after the > >>>> master > >>>>> > >>>>>> branch was closed as I hadn't made enough progress with the release > >>>> yet. > >>>>> > >>>>>> But that’s not the case now. > >>>>> > >>>>>> > >>>>> > >>>>>> Unless DRILL-7781 is a release blocker, we should probably skip it. > >> So > >>>>> far, > >>>>> > >>>>>> a lot of effort has gone into getting RC0 ready. So I'm hoping to > >> get > >>>>> this > >>>>> > >>>>>> closed asap. > >>>>> > >>>>>> > >>>>> > >>>>>> Regards, > >>>>> > >>>>>> Abhishek > >>>>> > >>>>>> > >>>>> > >>>>>> On Sun, Aug 30, 2020 at 6:07 PM Charles Givre <[email protected]> > >>>> wrote: > >>>>> > >>>>>> > >>>>> > >>>>>>> HI Abhishek, > >>>>> > >>>>>>> > >>>>> > >>>>>>> Can we merge DRILL-7781? We really shouldn't ship something with a > >>>>> simple > >>>>> > >>>>>>> bug like this. > >>>>> > >>>>>>> > >>>>> > >>>>>>> -- C > >>>>> > >>>>>>> > >>>>> > >>>>>>> > >>>>> > >>>>>>> > >>>>> > >>>>>>> > >>>>> > >>>>>>> > >>>>> > >>>>>>>> On Aug 30, 2020, at 8:40 PM, Abhishek Girish <[email protected]> > >>>>> wrote: > >>>>> > >>>>>>> > >>>>> > >>>>>>>> > >>>>> > >>>>>>> > >>>>> > >>>>>>>> Advanced tests from [5] are also complete. All 7500+ tests passed, > >>>>> except > >>>>> > >>>>>>> > >>>>> > >>>>>>>> for a few relating to known resource issues (drillbit > >> connectivity / > >>>>> OOM > >>>>> > >>>>>>> > >>>>> > >>>>>>>> /...). Plus a few with the same symptoms as DRILL-7785. > >>>>> > >>>>>>> > >>>>> > >>>>>>>> > >>>>> > >>>>>>> > >>>>> > >>>>>>>> On Sun, Aug 30, 2020 at 2:17 PM Abhishek Girish < > >> [email protected] > >>>>> > >>>>> > >>>>>>> wrote: > >>>>> > >>>>>>> > >>>>> > >>>>>>>> > >>>>> > >>>>>>> > >>>>> > >>>>>>>>> Wanted to share an update on some of the testing I've done from > >> my > >>>>> side: > >>>>> > >>>>>>> > >>>>> > >>>>>>>>> > >>>>> > >>>>>>> > >>>>> > >>>>>>>>> All Functional tests from [5] (plus private Customer tests) are > >>>>> > >>>>>>> complete. > >>>>> > >>>>>>> > >>>>> > >>>>>>>>> 10,000+ tests have passed. However, I did see an issue with Hive > >>>> ORC > >>>>> > >>>>>>> tables > >>>>> > >>>>>>> > >>>>> > >>>>>>>>> (DRILL-7785). Need to investigate if it's a blocker for the > >>>> release. > >>>>> > >>>>>>> > >>>>> > >>>>>>>>> > >>>>> > >>>>>>> > >>>>> > >>>>>>>>> Of course, all unit tests (part of the AD repo) - for both > >> default > >>>> and > >>>>> > >>>>>>> > >>>>> > >>>>>>>>> 'mapr' profiles are also successful. > >>>>> > >>>>>>> > >>>>> > >>>>>>>>> > >>>>> > >>>>>>> > >>>>> > >>>>>>>>> > >>>>> > >>>>>>> > >>>>> > >>>>>>>>> > >>>>> > >>>>>>> > >>>>> > >>>>>>>>> [5] https://github.com/mapr/drill-test-framework > >>>>> > >>>>>>> > >>>>> > >>>>>>>>> > >>>>> > >>>>>>> > >>>>> > >>>>>>>>> On Sun, Aug 30, 2020 at 10:14 AM Abhishek Girish < > >>>> [email protected]> > >>>>> > >>>>>>> > >>>>> > >>>>>>>>> wrote: > >>>>> > >>>>>>> > >>>>> > >>>>>>>>> > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> Hi all, > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> I'd like to propose the first release candidate (RC0) of Apache > >>>>> Drill, > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> version 1.18.0. > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> The release candidate covers a total of 164 resolved JIRAs [1]. > >>>>> Thanks > >>>>> > >>>>>>> to > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> everyone who contributed to this release. > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> The tarball artifacts are hosted at [2] and the maven artifacts > >>>> are > >>>>> > >>>>>>> hosted > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> at [3]. > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> This release candidate is based on commit > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> 91678ca6a48509b11530f1ce6c3d75fc9f4eadc0 located at [4]. > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> The vote ends at 17:00 PM UTC (10:00 AM PDT, 7:00 PM EET, 10:30 > >> PM > >>>>> > >>>>>>> IST), > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> Sep 2, 2020. > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> [ ] +1 > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> [ ] +0 > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> [ ] -1 > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> Here's my vote: +1 (non-binding). Please note that while all > >> votes > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> matter, only PMC votes are binding. > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> [1] > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> > >>>>> > >>>>>>> > >>>>> > >>>> > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12345459&styleName=Html&projectId=12313820 > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> [2] http://home.apache.org/~agirish/drill/releases/1.18.0/rc0/ > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> [3] > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> > >>>>> > >>>>>>> > >>>> > https://repository.apache.org/content/repositories/orgapachedrill-1080/ > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> [4] https://github.com/agirish/drill/commits/drill-1.18.0 > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> Regards, > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> Abhishek > >>>>> > >>>>>>> > >>>>> > >>>>>>>>>> > >>>>> > >>>>>>> > >>>>> > >>>>>>>>> > >>>>> > >>>>>>> > >>>>> > >>>>>>> > >>>>> > >>>>>>> > >>>>> > >>>>>>> > >>>>> > >>>>> > >>>>> > >>>>> > >>>> > >>> > >> > >
