I can attach a patch to the bug report with the changes necessary. It's part of my job at the moment.
Thanks, Allan On Fri, Jun 14, 2013 at 12:06 PM, Edward Sargisson <[email protected]> wrote: > Hi Allan, > Ok - that looks to be good enough to raise a defect report - so I have: > https://issues.apache.org/jira/browse/FLUME-2089 > > Feel free to review, edit and add details. > > I don't believe I can justify using my employer's time to fix this so > hopefully others may feel moved to fix it. > > Cheers, > Edward > > "After even further investigation, it seems the ContentBuilderUtil > calls org.elasticsearch. > common.xcontent.XContentFactory, specifically the xContentType method seen > here: > > > https://github.com/elasticsearch/elasticsearch/blob/master/src/main/java/org/elasticsearch/common/xcontent/XContentFactory.java#L116 > > If that function returns null, then it just tries to force the data to be > a string, otherwise it does some magic parsing based on the contentType. I > believe that this is where the problem happens. The xContentType function > thinks my string is YAML, then the YAML parser fails and isn't caught. Does > it make sense to have the try/catch in addComplexField catch the YAML > exception and fall back to using a addSimpleField? It seems the code > already does this for JSON related exceptions. > > Thanks, > Allan" >
